test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V2] tests/iavf_flexible_descriptor: add private flag for vf vlan
  2021-03-03 16:44 [dts] [PATCH V2] tests/iavf_flexible_descriptor: add private flag for vf vlan sunqin
@ 2021-03-03 10:28 ` Sun, QinX
  2021-03-04  2:20   ` Zhao, HaiyangX
  0 siblings, 1 reply; 4+ messages in thread
From: Sun, QinX @ 2021-03-03 10:28 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Thursday, March 4, 2021 12:45 AM

Tested-by: Sun Qin <qinx.sun@intel.com>
 

[-- Attachment #2: TestIavfFlexibleDescriptor.log --]
[-- Type: application/octet-stream, Size: 696159 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V2] tests/iavf_flexible_descriptor: add private flag for vf vlan
@ 2021-03-03 16:44 sunqin
  2021-03-03 10:28 ` Sun, QinX
  0 siblings, 1 reply; 4+ messages in thread
From: sunqin @ 2021-03-03 16:44 UTC (permalink / raw)
  To: dts; +Cc: sunqin

At present, iavf can only receive packets with type value of 0x8100 by default,

if want to receive other type packets, need to set private flag.

Signed-off-by: sunqin <qinx.sun@intel.com>
---
v1: add private flag setting for vf vlan
v2: add commit message and restore setting after suite test is complete

 tests/TestSuite_iavf_flexible_descriptor.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_iavf_flexible_descriptor.py b/tests/TestSuite_iavf_flexible_descriptor.py
index 69f38bf6..3bfd5b99 100644
--- a/tests/TestSuite_iavf_flexible_descriptor.py
+++ b/tests/TestSuite_iavf_flexible_descriptor.py
@@ -79,13 +79,14 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):
             netdev.bind_driver(driver=self.kdriver)
         # set vf assign method and vf driver
         vf_driver = 'vfio-pci'
+        self.pf0_intf = self.dut.ports_info[self.dut_ports[dut_index]]['intf']
+        self.dut.send_expect('ethtool --set-priv-flags {} vf-vlan-prune-disable on'.format(self.pf0_intf),'#')
         # generate 2 VFs on PF
         self.dut.generate_sriov_vfs_by_port(
             used_dut_port, 1, driver=self.kdriver)
-        pf0_intf = self.dut.ports_info[self.dut_ports[dut_index]]['intf']
         vf_mac = "00:11:22:33:44:55"
         self.dut.send_expect(
-            'ip link set {} vf 0 mac {}'.format(pf0_intf, vf_mac), '#')
+            'ip link set {} vf 0 mac {}'.format(self.pf0_intf, vf_mac), '#')
         sriov_vf0 = self.dut.ports_info[used_dut_port]['vfs_port'][0]
         sriov_vf0.bind_driver(vf_driver)
         return sriov_vf0, vf_mac
@@ -122,6 +123,7 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):
         """
         self.destroy_vf()
         self.restore_compilation()
+        self.dut.send_expect('ethtool --set-priv-flags {} vf-vlan-prune-disable off'.format(self.pf0_intf), '#')
 
     def set_up(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/iavf_flexible_descriptor: add private flag for vf vlan
  2021-03-03 10:28 ` Sun, QinX
@ 2021-03-04  2:20   ` Zhao, HaiyangX
  2021-03-04  8:14     ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Zhao, HaiyangX @ 2021-03-04  2:20 UTC (permalink / raw)
  To: Sun, QinX, dts



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Sun, QinX
> Sent: Wednesday, March 3, 2021 18:28
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V2] tests/iavf_flexible_descriptor: add private flag
> for vf vlan
> 
> > -----Original Message-----
> > From: Sun, QinX <qinx.sun@intel.com>
> > Sent: Thursday, March 4, 2021 12:45 AM
> 
> Tested-by: Sun Qin <qinx.sun@intel.com>

Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/iavf_flexible_descriptor: add private flag for vf vlan
  2021-03-04  2:20   ` Zhao, HaiyangX
@ 2021-03-04  8:14     ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-03-04  8:14 UTC (permalink / raw)
  To: Zhao, HaiyangX, Sun, QinX, dts

> > > -----Original Message-----
> > > From: Sun, QinX <qinx.sun@intel.com>
> > > Sent: Thursday, March 4, 2021 12:45 AM
> > > At present, iavf can only receive packets with type value of 0x8100 by default,
> > > 
> > > if want to receive other type packets, need to set private flag.

>>> Signed-off-by: sunqin <qinx.sun@intel.com>
> >
> > Tested-by: Sun Qin <qinx.sun@intel.com>
> 
> Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-04  8:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 16:44 [dts] [PATCH V2] tests/iavf_flexible_descriptor: add private flag for vf vlan sunqin
2021-03-03 10:28 ` Sun, QinX
2021-03-04  2:20   ` Zhao, HaiyangX
2021-03-04  8:14     ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git