From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Ori Kam <orika@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce flow API matching pattern struct changes
Date: Mon, 23 Nov 2020 14:17:37 +0000 [thread overview]
Message-ID: <e02a158f-7d48-04b2-8f3c-55413460d8aa@intel.com> (raw)
In-Reply-To: <148925d7-2ebd-fcbb-0d7c-6cbe3d15a6de@oktetlabs.ru>
On 11/23/2020 1:50 PM, Andrew Rybchenko wrote:
> On 11/23/20 4:40 PM, Ferruh Yigit wrote:
>> Proposing to replace protocol header fields in the ``rte_flow_item_*``
>> structures with the protocol structs, like:
>>
>> Current ``struct rte_flow_item_eth``,
>>
>> struct rte_flow_item_eth {
>> struct rte_ether_addr dst;
>> struct rte_ether_addr src;
>> rte_be16_t type;
>> uint32_t has_vlan:1;
>> uint32_t reserved:31;
>> }
>>
>> will become
>>
>> struct rte_flow_item_eth {
>> struct rte_ether_hdr hdr;
>> uint32_t has_vlan:1;
>> uint32_t reserved:31;
>> }
>>
>> This is both for documenting the intention and to be sure
>> ``rte_flow_item_*`` always starts with complete protocol header.
>>
>> Already many ``rte_flow_item_*`` structs implemented to have protocol
>> struct, target is convert all to this usage.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> a minor note below
>
>> ---
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Cc: Ori Kam <orika@nvidia.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 96986fabd598..a2fa0c196472 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -88,6 +88,13 @@ Deprecation Notices
>> will be limited to maximum 256 queues.
>> Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.
>>
>> +* ethdev: The flow API matching pattern structures, ``struct rte_flow_item_*``,
>> + should start with relevant protocol header.
>> + Some matching pattern structures implements this by duplicating protocol header
>> + fields in the struct. To clarify the intention and to be sure protocol header
>> + is intact, will replace those fields with relevant protocol header struct.
>> + Target is v21.02 release and this should not change the ABI.
>> +
>> * sched: To allow more traffic classes, flexible mapping of pipe queues to
>> traffic classes, and subport level configuration of pipes and queues
>> changes will be made to macros, data structures and API functions defined
>>
>
> Just want to highlight that even API could be kept using
> unnamed union for hdr and unnamed structure for existing
> protocol header fields.
>
Then we may never clean the protocol header fields out of it,
yes this will impact the user but I believe the impact is small and trivial,
I prefer replacing fields with protocol struct.
next prev parent reply other threads:[~2020-11-23 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 13:40 Ferruh Yigit
2020-11-23 13:50 ` Andrew Rybchenko
2020-11-23 14:17 ` Ferruh Yigit [this message]
2020-11-23 14:25 ` Andrew Rybchenko
2020-11-23 15:51 ` Ferruh Yigit
2020-11-24 11:43 ` Ori Kam
2020-11-24 12:56 ` Ferruh Yigit
2020-11-24 13:00 ` Andrew Rybchenko
2020-11-24 13:01 ` Andrew Rybchenko
2020-11-24 13:15 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2020-11-24 14:29 ` Ajit Khaparde
2020-11-27 17:56 ` Thomas Monjalon
2020-11-27 16:16 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02a158f-7d48-04b2-8f3c-55413460d8aa@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).