From: "Yigit, Ferruh" <ferruh.yigit@linux.intel.com>
To: Jakub Grajciar <jgrajcia@cisco.com>,
dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave
Date: Fri, 25 Oct 2019 17:44:50 +0100 [thread overview]
Message-ID: <e037e60d-0d29-8849-8dbe-c24a08b85613@linux.intel.com> (raw)
In-Reply-To: <20190822081833.11203-1-jgrajcia@cisco.com>
On 8/22/2019 9:18 AM, Jakub Grajciar wrote:
> Zero-copy slave support for memif PMD.
> Slave interface exposes DPDK memory to
> master interface. Only single file segments
> are supported (EAL option --single-file-segments).
>
> Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Since bind() issue solved, we can continue with the patch.
<...>
> @@ -131,7 +132,7 @@ struct pmd_process_private {
> * @param proc_private
> * device process private data
> */
> -void memif_free_regions(struct pmd_process_private *proc_private);
> +void memif_free_regions(struct rte_eth_dev *dev);
>
> /**
> * Finalize connection establishment process. Map shared memory file
> diff --git a/lib/librte_eal/common/eal_common_mcfg.c b/lib/librte_eal/common/eal_common_mcfg.c
> index 066549432..03d9d472d 100644
> --- a/lib/librte_eal/common/eal_common_mcfg.c
> +++ b/lib/librte_eal/common/eal_common_mcfg.c
> @@ -161,3 +161,10 @@ rte_mcfg_timer_unlock(void)
> struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
> rte_spinlock_unlock(&mcfg->tlock);
> }
> +
> +uint32_t
> +rte_mcfg_get_single_file_segments(void)
> +{
> + struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
> + return mcfg->single_file_segments;
> +}
> diff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h b/lib/librte_eal/common/include/rte_eal_memconfig.h
> index 34b0e44a0..9bb4a57f8 100644
> --- a/lib/librte_eal/common/include/rte_eal_memconfig.h
> +++ b/lib/librte_eal/common/include/rte_eal_memconfig.h
> @@ -109,6 +109,16 @@ __rte_experimental
> void
> rte_mcfg_timer_unlock(void);
>
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * Get the single_file_segments parameter value from memory configuration.
> + */
> +__rte_experimental
> +uint32_t
> +rte_mcfg_get_single_file_segments(void);
> +
> #ifdef __cplusplus
> }
> #endif
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 7cbf82d37..c2b9d473f 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -418,5 +418,6 @@ EXPERIMENTAL {
> rte_lcore_to_cpu_id;
> rte_mcfg_timer_lock;
> rte_mcfg_timer_unlock;
> + rte_mcfg_get_single_file_segments;
This should be moved to 19.11 block in experimental
cc'ed Dave for eal part,
@Dave, change looks straight forward but can you please check/comment?
next prev parent reply other threads:[~2019-10-25 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 8:22 [dpdk-dev] [PATCH v4] " Jakub Grajciar
2019-07-10 15:06 ` Ferruh Yigit
2019-07-23 12:35 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-08-22 8:18 ` [dpdk-dev] [PATCH v5] " Jakub Grajciar
2019-10-04 13:23 ` Ferruh Yigit
2019-10-15 16:59 ` Ferruh Yigit
2019-10-17 11:52 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-17 16:04 ` Ferruh Yigit
2019-10-17 16:45 ` Ferruh Yigit
2019-10-21 16:07 ` Ferruh Yigit
2019-10-25 16:44 ` Yigit, Ferruh [this message]
2019-10-29 14:28 ` David Marchand
2019-10-30 10:17 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2019-10-30 10:25 ` David Marchand
2019-11-04 11:03 ` [dpdk-dev] [PATCH v6] " Jakub Grajciar
2019-11-11 15:21 ` Ferruh Yigit
2019-11-11 15:24 ` Thomas Monjalon
2019-11-12 12:55 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2019-11-11 15:49 ` David Marchand
2019-11-15 16:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e037e60d-0d29-8849-8dbe-c24a08b85613@linux.intel.com \
--to=ferruh.yigit@linux.intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).