From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xiao Wang <xiao.w.wang@intel.com>, dev@dpdk.org
Cc: jianfeng.tan@intel.com, tiwei.bie@intel.com,
yliu@fridaylinux.org, cunming.liang@intel.com,
dan.daly@intel.com, zhihong.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/3] net/vdpa_virtio_pci: introduce vdpa sample driver
Date: Tue, 6 Feb 2018 15:24:19 +0100 [thread overview]
Message-ID: <e0530d3b-83e7-b930-3782-c65c63863f5f@redhat.com> (raw)
In-Reply-To: <20180204145542.38345-3-xiao.w.wang@intel.com>
Hi Xiao,
On 02/04/2018 03:55 PM, Xiao Wang wrote:
> This driver is a reference sample of making vDPA device driver based
> on vhost lib, this driver uses a standard virtio-net PCI device as
> vDPA device, it can serve as a backend for a virtio-net pci device
> in nested VM.
>
> The key driver ops implemented are:
>
> * vdpa_virtio_eng_init
> Mapping virtio pci device with VFIO into userspace, and read device
> capability and intialize internal data.
>
> * vdpa_virtio_eng_uninit
> Release the mapped device.
>
> * vdpa_virtio_info_query
> Device capability reporting, e.g. queue number, features.
>
> * vdpa_virtio_dev_config
> With the guest virtio information provideed by vhost lib, this
> function configures device and IOMMU to set up vhost datapath,
> which includes: Rx/Tx vring, VFIO interrupt, kick relay.
>
> * vdpa_virtio_dev_close
> Unset the stuff that are configured previously by dev_conf.
>
> This driver requires the virtio device supports VIRTIO_F_IOMMU_PLATFORM
> , because the buffer address written in desc is IOVA.
>
> Because vDPA driver needs to set up MSI-X vector to interrupt the guest,
> only vfio-pci is supported currently.
>
> Signed-off-by: Xiao Wang<xiao.w.wang@intel.com>
> ---
> config/common_base | 6 +
> config/common_linuxapp | 1 +
> drivers/net/Makefile | 1 +
> drivers/net/vdpa_virtio_pci/Makefile | 31 +
> .../net/vdpa_virtio_pci/rte_eth_vdpa_virtio_pci.c | 1527 ++++++++++++++++++++
> .../rte_vdpa_virtio_pci_version.map | 4 +
> mk/rte.app.mk | 1 +
> 7 files changed, 1571 insertions(+)
> create mode 100644 drivers/net/vdpa_virtio_pci/Makefile
> create mode 100644 drivers/net/vdpa_virtio_pci/rte_eth_vdpa_virtio_pci.c
> create mode 100644 drivers/net/vdpa_virtio_pci/rte_vdpa_virtio_pci_version.map
Is there a specific constraint that makes you expose PCI functions and
duplicate a lot of vfio code into the driver?
Wouldn't it be better (if possible) to use RTE_PMD_REGISTER_PCI() & co.
to benefit from all the existing infrastructure?
Maxime
next prev parent reply other threads:[~2018-02-06 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 14:55 [dpdk-dev] [PATCH 0/3] add vDPA " Xiao Wang
2018-02-04 14:55 ` [dpdk-dev] [PATCH 1/3] bus/pci: expose API for vDPA Xiao Wang
2018-02-04 14:55 ` [dpdk-dev] [PATCH 2/3] net/vdpa_virtio_pci: introduce vdpa sample driver Xiao Wang
2018-02-06 14:24 ` Maxime Coquelin [this message]
2018-02-08 2:23 ` Wang, Xiao W
2018-02-08 9:08 ` Maxime Coquelin
2018-02-12 15:36 ` Wang, Xiao W
2018-02-04 14:55 ` [dpdk-dev] [PATCH 3/3] examples/vdpa: add a new sample for vdpa Xiao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0530d3b-83e7-b930-3782-c65c63863f5f@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yliu@fridaylinux.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).