From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>,
Thomas Monjalon <thomas@monjalon.net>,
olivier.matz@6wind.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print
Date: Tue, 21 Nov 2017 10:10:40 -0800 [thread overview]
Message-ID: <e0720852-3bf1-a2ad-a3ac-91b59cc9b315@intel.com> (raw)
In-Reply-To: <20171121140451.hq4niywykhqgvzbx@Pavan-LT>
On 11/21/2017 6:04 AM, Pavan Nikhilesh Bhagavatula wrote:
> On Tue, Nov 21, 2017 at 02:30:48PM +0100, Thomas Monjalon wrote:
>> 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula:
>>> On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote:
>>>> 20/11/2017 19:40, Ferruh Yigit:
> <snip>
>>>
>>> I will be sending out the patch set soon.
>>
>> These are only the legacy static log types.
>> Are you sure you want to change them?
>> They should be removed when using dynamic logging.
>
> Actually this same struct is used for registering dynamic logs for legacy
> modules currently,
>
> /* register legacy log types */
> for (i = 0; i < RTE_DIM(logtype_strings); i++)
> __rte_log_register(logtype_strings[i].logtype,
> logtype_strings[i].log_id);
>
> I have just prefixed them with "lib.". If we remove this form here then each
> module has to use constructor style initialisation for logs which would be a
> lot of rework.
That work of each library registering dynamic log themselves needs to be done
somehow but that is bigger task, for this patch just renaming static ones to be
consistent can be enough I think.
Thanks,
ferruh
prev parent reply other threads:[~2017-11-21 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 10:31 [dpdk-dev] [PATCH 1/2] eal: fix legacy dynamic logs defaulting to debug Pavan Nikhilesh
2017-11-16 10:31 ` [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print Pavan Nikhilesh
2017-11-16 19:48 ` Ferruh Yigit
2017-11-17 8:47 ` Pavan Nikhilesh Bhagavatula
2017-11-20 18:40 ` Ferruh Yigit
2017-11-21 8:30 ` Pavan Nikhilesh Bhagavatula
2017-11-21 10:55 ` Thomas Monjalon
2017-11-21 11:14 ` Pavan Nikhilesh Bhagavatula
2017-11-21 13:30 ` Thomas Monjalon
2017-11-21 14:04 ` Pavan Nikhilesh Bhagavatula
2017-11-21 18:10 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0720852-3bf1-a2ad-a3ac-91b59cc9b315@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).