From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,
david.marchand@redhat.com, ferruh.yigit@intel.com,
michaelba@nvidia.com, viacheslavo@nvidia.com
Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-stable] [PATCH 1/3] net/virtio: add initial RSS support
Date: Fri, 10 Sep 2021 13:06:05 +0300 [thread overview]
Message-ID: <e0ffbafa-1956-5390-6b31-c416893b26a7@oktetlabs.ru> (raw)
In-Reply-To: <20210910091734.7023-2-maxime.coquelin@redhat.com>
On 9/10/21 12:17 PM, Maxime Coquelin wrote:
> This patch adds RSS support to the Virtio PMD. It provides
I'd drop the first sentence since summary already says so and
suggest to start the second from "Provide ..."
> the capability to update the hash key, hash types and reta
reta -> RETA (see devtools/words-case.txt)
> table on the fly (without needing to stop/start the
> device). However, the key length and the number of reta
reta -> RETA
> entries are fixed to 40B and 128 entries respectively. This
> is done in order to simplify the design, but may be
> revisited later as the Virtio spec provides this
> flexibility.
I've failed to find F_RSS definion in virtio spec.
Could you share the reference, please.
Without the sepc it is almost impossible to review the code.
>
> Note that only VIRTIO_NET_F_RSS support is implemented,
> VIRTIO_NET_F_HASH_REPORT, which would enable reporting the
> packet RSS hash calculated by the device into mbuf.rss, is
> not yet supported.
>
> Regarding the default RSS configuration, it has been
> chosen to use the default Intel ixgbe key as default key,
> and default reta is a simple modulo between the hash and
reta -> RETA
> the number of Rx queues.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> doc/guides/nics/features/virtio.ini | 2 +
> doc/guides/nics/virtio.rst | 3 +
> doc/guides/rel_notes/release_21_11.rst | 5 +
> drivers/net/virtio/virtio.h | 31 ++-
> drivers/net/virtio/virtio_ethdev.c | 367 ++++++++++++++++++++++++-
> drivers/net/virtio/virtio_ethdev.h | 3 +-
> drivers/net/virtio/virtqueue.h | 21 ++
> 7 files changed, 426 insertions(+), 6 deletions(-)
>
> diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini
> index 48f6f393b1..883dd1426c 100644
> --- a/doc/guides/nics/features/virtio.ini
> +++ b/doc/guides/nics/features/virtio.ini
> @@ -14,6 +14,8 @@ Promiscuous mode = Y
> Allmulticast mode = Y
> Unicast MAC filter = Y
> Multicast MAC filter = Y
I'd say that
RSS has = P
should be added here.
> +RSS key update = Y
> +RSS reta update = Y
> VLAN filter = Y
> Basic stats = Y
> Stats per queue = Y
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
> index 82ce7399ce..6e451cd67c 100644
> --- a/doc/guides/nics/virtio.rst
> +++ b/doc/guides/nics/virtio.rst
> @@ -73,6 +73,9 @@ In this release, the virtio PMD driver provides the basic functionality of packe
>
> * Virtio supports using port IO to get PCI resource when UIO module is not available.
>
> +* Virtio supports RSS Rx mode with 40B configurable hash key len, 128
len -> length
> + configurable reta entries and configurable hash types.
reta -> RETA
> +
> Prerequisites
> -------------
>
> diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
> index d707a554ef..21d2b09838 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -55,6 +55,11 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> + * **Added initial RSS support to Virtio PMD.**
> +
> + Initial support for RSS receive mode has been added to the Virtio PMD,
> + with the capability for the application to configure the hash Key, the
> + reta and the hash types. Virtio hash reporting is yet to be added.
reta -> RETA
Please, add one more empty line to have two empty lines
before the next section.
>
> Removed Items
> -------------
[snip]
next prev parent reply other threads:[~2021-09-10 10:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 9:17 [dpdk-stable] [PATCH 0/3] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-10 9:17 ` [dpdk-stable] [PATCH 1/3] net/virtio: add initial RSS support Maxime Coquelin
2021-09-10 10:06 ` Andrew Rybchenko [this message]
2021-09-10 11:44 ` Maxime Coquelin
2021-09-10 12:58 ` Andrew Rybchenko
2021-09-10 13:10 ` Maxime Coquelin
2021-09-10 9:17 ` [dpdk-stable] [PATCH 2/3] app/testpmd: fix RSS hash type update Maxime Coquelin
2021-09-10 9:51 ` Andrew Rybchenko
2021-09-10 9:57 ` Maxime Coquelin
2021-09-10 10:06 ` Andrew Rybchenko
2021-09-10 14:16 ` Nélio Laranjeiro
2021-09-13 9:41 ` Maxime Coquelin
2021-09-14 7:20 ` Nélio Laranjeiro
2021-09-16 3:03 ` Li, Xiaoyun
2021-09-16 7:33 ` Maxime Coquelin
2021-09-16 7:41 ` Li, Xiaoyun
2021-09-16 8:08 ` Maxime Coquelin
2021-09-16 8:30 ` Li, Xiaoyun
2021-09-10 9:17 ` [dpdk-stable] [PATCH 3/3] net/mlx5: Fix RSS RETA update Maxime Coquelin
2021-09-21 9:55 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0ffbafa-1956-5390-6b31-c416893b26a7@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=michaelba@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).