From: "Doherty, Declan" <declan.doherty@intel.com>
To: Ciara Power <ciara.power@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, gakhil@marvell.com, aconole@redhat.com,
hemant.agrawal@nxp.com, anoobj@marvell.com, ruifeng.wang@arm.com,
asomalap@amd.com, ajit.khaparde@broadcom.com, g.singh@nxp.com
Subject: Re: [dpdk-dev] [PATCH v3 3/7] test/crypto: refactor to use sub-testsuites
Date: Fri, 30 Apr 2021 21:59:10 +0100 [thread overview]
Message-ID: <e104942b-f727-0eb0-48e0-a4380f3e76a0@intel.com> (raw)
In-Reply-To: <20210423161820.2135053-4-ciara.power@intel.com>
On 23/04/2021 5:18 PM, Ciara Power wrote:
> The existing implementation runs a giant cryptodev testsuite for most
> autotests, which in turns runs one setup function regardless of device.
>
> This is now broken down into multiple testsuites,
> that are used as sub-testsuites. Each autotest runs a general crypto
> parent test suite, to which the sub-testsuites are added.
>
> For example, the AESNI_MB test runs "Cryptodev Unit Test Suite",
> which has a setup function only to configure testsuite params.
> Creation of vdevs in the setup function is no longer supported,
> it is expected the user does this when running the app.
> This autotest previously just ran the cryptodev_testsuite,
> but now has the smaller sub-testsuites added to the parent suite instead.
> The same test cases are being run as before.
>
> The scheduler autotest creates its own parent testsuite with nested
> sub-testsuites, rather than using the cryptodev testsuite mentioned above.
> This is due to it being more complex in execution,
> by requiring setting different modes before running tests.
> The scheduler autotest no longer requires the extra test cases to
> attach/set mode/detach when running the blockcipher test cases for
> each mode. The attach/set mode/detach functionality is now tested in a
> sub-testsuite. When running the sub-testsuites for each mode,
> the attach/set mode/detach happens in the setup and teardown functions
> for that sub-testsuite.
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
>
....
>
Hey Ciara, can you make sure to detail the new requirement in the unit
test documentation about the need to create the sw crypto pmds using the
--vdev EAL arguments.
next prev parent reply other threads:[~2021-04-30 20:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 16:18 [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework Ciara Power
2021-04-23 16:18 ` [dpdk-dev] [PATCH v3 1/7] app/test: refactor of unit test suite runner Ciara Power
2021-04-23 16:18 ` [dpdk-dev] [PATCH v3 2/7] test: introduce parent testsuite format Ciara Power
2021-04-23 16:32 ` Aaron Conole
2021-04-23 16:18 ` [dpdk-dev] [PATCH v3 3/7] test/crypto: refactor to use sub-testsuites Ciara Power
2021-04-30 20:59 ` Doherty, Declan [this message]
2021-04-23 16:18 ` [dpdk-dev] [PATCH v3 4/7] test/crypto: replace unsupported with skipped Ciara Power
2021-04-23 16:18 ` [dpdk-dev] [PATCH v3 5/7] test/crypto: move testsuite params to header file Ciara Power
2021-04-23 16:18 ` [dpdk-dev] [PATCH v3 6/7] test/crypto: fix return value on test skipped Ciara Power
2021-04-23 16:18 ` [dpdk-dev] [PATCH v3 7/7] test/crypto: dynamically build blockcipher suite Ciara Power
2021-04-25 9:24 ` [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework Ruifeng Wang
2021-04-30 21:00 ` Doherty, Declan
2021-05-05 10:41 ` Hemant Agrawal
2021-05-05 12:20 ` Hemant Agrawal
2021-05-08 15:38 ` [dpdk-dev] [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e104942b-f727-0eb0-48e0-a4380f3e76a0@intel.com \
--to=declan.doherty@intel.com \
--cc=aconole@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=anoobj@marvell.com \
--cc=asomalap@amd.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).