From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Amr Mokhtar <amr.mokhtar@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, anatoly.burakov@intel.com,
pablo.de.lara.guarch@intel.com, niall.power@intel.com,
chris.macnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH v4 1/5] bbdev: introducing wireless base band device (BBDEV) abstraction library
Date: Tue, 9 Jan 2018 19:17:59 +0000 [thread overview]
Message-ID: <e15a3788-8e11-e037-e36b-debd9da2935c@intel.com> (raw)
In-Reply-To: <1513990331-20253-1-git-send-email-amr.mokhtar@intel.com>
On 12/23/2017 12:52 AM, Amr Mokhtar wrote:
> - wireless baseband device (bbdev) library files
> - bbdev is tagged as EXPERIMENTAL
> - makefiles and configuration macros definition
> - bbdev library is enabled by default
> - release notes of the initial version
Hi Amr,
Overall lgtm:
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
There are a few minor things commented below, can you please check them?
You can keep my ack with next version.
./devtools/check-git-log.sh complaining about patch title, same with some of the
other patches, can you please update them?
>
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
<...>
> @@ -593,6 +593,13 @@ CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV_DEBUG=n
> CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=y
> CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF_DEBUG=n
>
> +# Compile generic wireless base band device library
> +# EXPERIMENTAL: API may change without prior notice
> +#
> +CONFIG_RTE_LIBRTE_BBDEV=y
> +CONFIG_RTE_LIBRTE_BBDEV_DEBUG=n
It seems this option is not used now.
<...>
> @@ -0,0 +1,586 @@
> +..
> + SPDX-License-Identifier: BSD-3-Clause
> + Copyright(c) 2017 Intel Corporation
Minor issue but can you please move SPDX to first line, same for a few more
documents.
<...>
> +/* Find data alocated for the device or if not found return first unused bbdev
> + * data. If all structures are in use and none is used by the device return
> + * NULL.
> + */
If this kind of comment syntax because of checkpatch warning you can ignore it, fyi.
<...>
prev parent reply other threads:[~2018-01-09 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 0:52 Amr Mokhtar
2017-12-23 0:52 ` [dpdk-dev] [PATCH v4 2/5] bbdev: PMD drivers (1. bbdev_null) Amr Mokhtar
2018-01-09 19:18 ` Ferruh Yigit
2017-12-23 0:52 ` [dpdk-dev] [PATCH v4 3/5] bbdev: PMD drivers (2. turbo_sw) Amr Mokhtar
2018-01-09 19:18 ` Ferruh Yigit
2017-12-23 0:52 ` [dpdk-dev] [PATCH v4 4/5] bbdev: test applications Amr Mokhtar
2018-01-09 19:27 ` Ferruh Yigit
2017-12-23 0:52 ` [dpdk-dev] [PATCH v4 5/5] bbdev: sample app Amr Mokhtar
2017-12-23 0:52 ` [dpdk-dev] [PATCH v4 0/5] Introducing Wirless Base Band Device (bbdev) abstraction library Amr Mokhtar
2018-01-09 19:17 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e15a3788-8e11-e037-e36b-debd9da2935c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=amr.mokhtar@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=chris.macnamara@intel.com \
--cc=dev@dpdk.org \
--cc=niall.power@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).