DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Michał Krawczyk" <mk@semihalf.com>, "Rafal Kozik" <rk@semihalf.com>
Cc: dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
	"Tzalik, Guy" <gtzalik@amazon.com>,
	"Schmeilin, Evgeny" <evgenys@amazon.com>,
	"Matushevsky, Alexander" <matua@amazon.com>,
	"Chauskin, Igor" <igorch@amazon.com>
Subject: Re: [dpdk-dev] [PATCH] net/ena: fix jumbo support in Rx offloads flags
Date: Thu, 1 Feb 2018 16:49:27 +0000	[thread overview]
Message-ID: <e15a4e68-6128-343b-85f0-a62b9cfad789@intel.com> (raw)
In-Reply-To: <CAJMMOfPXdCT=_vx=2Or2vBLnCpgoabZ_h5Am7EAhsjeZYBqpnA@mail.gmail.com>

On 2/1/2018 4:36 PM, Michał Krawczyk wrote:
> 2018-02-01 14:06 GMT+01:00 Rafal Kozik <rk@semihalf.com>:
>>
>> ENA device supports Rx jumbo frames and such information needs to
>> be provided in the offloads flags.
>>
>> Fixes:  7369f88f88c0 ("net/ena: convert to new Rx offloads API")
>>
>> Signed-off-by: Rafal Kozik <rk@semihalf.com>
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>

Hi Michał,

Are you claiming your right on the patch as developer?

Or is the intention to ack the patch?
  Acked-by: Michal Krawczyk <mk@semihalf.com>

>>
>> ---
>>  drivers/net/ena/ena_ethdev.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
>> index 83e0ae2..3588384 100644
>> --- a/drivers/net/ena/ena_ethdev.c
>> +++ b/drivers/net/ena/ena_ethdev.c
>> @@ -1561,6 +1561,8 @@ static void ena_infos_get(struct rte_eth_dev *dev,
>>                         DEV_RX_OFFLOAD_UDP_CKSUM  |
>>                         DEV_RX_OFFLOAD_TCP_CKSUM;
>>
>> +       rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME;
>> +
>>         /* Inform framework about available features */
>>         dev_info->rx_offload_capa = rx_feat;
>>         dev_info->rx_queue_offload_capa = rx_feat;
>> --
>> 2.7.4
>>

  reply	other threads:[~2018-02-01 16:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 13:06 Rafal Kozik
2018-02-01 16:36 ` Michał Krawczyk
2018-02-01 16:49   ` Ferruh Yigit [this message]
2018-02-01 16:52     ` Michał Krawczyk
2018-02-05 15:47       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e15a4e68-6128-343b-85f0-a62b9cfad789@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=evgenys@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=matua@amazon.com \
    --cc=mk@semihalf.com \
    --cc=mw@semihalf.com \
    --cc=rk@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).