From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rafal Kozik <rk@semihalf.com>, dev@dpdk.org
Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com,
evgenys@amazon.com, matua@amazon.com, igorch@amazon.com,
john.mcnamara@intel.com, marko.kovacevic@intel.com,
zorik@amazon.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] doc: update for ENA supported drivers
Date: Tue, 9 Oct 2018 11:56:07 +0100 [thread overview]
Message-ID: <e15b1856-74c7-8095-da37-2d7692df389d@intel.com> (raw)
In-Reply-To: <1538730173-7444-1-git-send-email-rk@semihalf.com>
On 10/5/2018 10:02 AM, Rafal Kozik wrote:
> Add instruction how to bind ENA to VFIO-PCI driver.
>
> Fixes: cf8a122c296a ("ena: introduce documentation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Zorik Machulsky <zorik@amazon.com>
> Signed-off-by: Rafal Kozik <rk@semihalf.com>
> Acked-by: Michal Krawczyk <mk@semihalf.com>
> ---
> doc/guides/nics/ena.rst | 12 +++++++++---
> doc/guides/nics/features/ena.ini | 1 +
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst
> index d19912e..0dfefc6 100644
> --- a/doc/guides/nics/ena.rst
> +++ b/doc/guides/nics/ena.rst
> @@ -187,11 +187,17 @@ Prerequisites
> -------------
>
> #. Prepare the system as recommended by DPDK suite. This includes environment
> - variables, hugepages configuration, tool-chains and configuration
> + variables, hugepages configuration, tool-chains and configuration.
>
> -#. Insert igb_uio kernel module using the command 'modprobe igb_uio'
> +#. ENA PMD can operate with vfio-pci or igb_uio driver.
>
> -#. Bind the intended ENA device to igb_uio module
> +#. Insert vfio-pci or igb_uio kernel module using the command
> + 'modprobe vfio-pci' or 'modprobe igb_uio' respectively.
Unless installed "igb_uio" won't be available to use with "modprobe", not sure
about adding that detail, what do you think?
> +
> +#. If vfio-pci driver is used please make sure noiommu mode is enabled:
> + echo 1 > /sys/module/vfio/parameters/enable_unsafe_noiommu_mode
This is only required if there is no iommu on the system, right? Won't ena will
work without this parameter on the system that has iommu?
> +
> +#. Bind the intended ENA device to vfio-pci or igb_uio module.
>
>
> At this point the system should be ready to run DPDK applications. Once the
> diff --git a/doc/guides/nics/features/ena.ini b/doc/guides/nics/features/ena.ini
> index 691c1e3..aa6f05a 100644
> --- a/doc/guides/nics/features/ena.ini
> +++ b/doc/guides/nics/features/ena.ini
> @@ -23,5 +23,6 @@ Inner L4 checksum = Y
> Basic stats = Y
> Extended stats = Y
> Linux UIO = Y
> +Linux VFIO = Y
> x86-32 = Y
> x86-64 = Y
>
next prev parent reply other threads:[~2018-10-09 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 9:02 Rafal Kozik
2018-10-09 10:56 ` Ferruh Yigit [this message]
2018-10-10 12:04 ` Rafał Kozik
2018-10-10 12:08 ` [dpdk-stable] [PATCH v2] " Rafal Kozik
2018-10-11 10:37 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e15b1856-74c7-8095-da37-2d7692df389d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=matua@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=rk@semihalf.com \
--cc=stable@dpdk.org \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).