From: Sinan Kaya <okaya@kernel.org>
To: Thomas Monjalon <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org
Subject: Re: [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name
Date: Mon, 06 Feb 2023 11:01:36 -0500 [thread overview]
Message-ID: <e1a8e9a64dc676fdd5da3b0cf39a8e34e83dac70.camel@kernel.org> (raw)
In-Reply-To: <4942344.1oUyQt6lIG@thomas>
On Sun, 2023-01-22 at 21:51 +0100, Thomas Monjalon wrote:
> 20/01/2023 17:47, Stephen Hemminger:
> > On Thu, 19 Jan 2023 23:41:40 -0500
> > okaya@kernel.org wrote:
> >
> > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h
> > > index 364f140f91..6d94a65d97 100644
> > > --- a/lib/ethdev/ethdev_vdev.h
> > > +++ b/lib/ethdev/ethdev_vdev.h
> > > @@ -34,6 +34,8 @@ rte_eth_vdev_allocate(struct rte_vdev_device
> > > *dev, size_t private_data_size)
> > > {
> > > struct rte_eth_dev *eth_dev;
> > > const char *name = rte_vdev_device_name(dev);
> > > + if (name == NULL)
> > > + return NULL;
> >
> > Please add a blank line after declarations and before code.
> > For some reason the DPDK version of checkpatch suppresses this
> > warning.
>
> The check of "name" is related to the line above,
> so I don't think we should insert a blank line.
>
>
While I'm waiting for maintainer feedback, let me know which
way I should go. I can update this for next rev.
next prev parent reply other threads:[~2023-02-06 16:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 4:41 [PATCH v3 00/10] codeql fixes for various subsystems okaya
2023-01-20 4:41 ` [PATCH v3 01/10] ethdev: check return result of rte_eth_dev_info_get okaya
2023-01-20 10:21 ` Morten Brørup
2023-01-20 4:41 ` [PATCH v3 02/10] memzone: check result of rte_fbarray_get okaya
2023-01-20 4:41 ` [PATCH v3 03/10] memzone: check result of malloc_elem_from_data okaya
2023-01-20 4:41 ` [PATCH v3 04/10] malloc: malloc_elem_join_adjacent_free can return null okaya
2023-01-20 4:41 ` [PATCH v3 05/10] malloc: check result of rte_mem_virt2memseg_list okaya
2023-01-20 4:41 ` [PATCH v3 06/10] malloc: check result of rte_fbarray_get okaya
2023-01-20 4:41 ` [PATCH v3 07/10] malloc: check result of rte_mem_virt2memseg okaya
2023-01-20 4:41 ` [PATCH v3 08/10] malloc: check result of malloc_elem_free okaya
2023-01-20 4:41 ` [PATCH v3 09/10] malloc: check result of elem_start_pt okaya
2023-01-20 4:41 ` [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name okaya
2023-01-20 16:47 ` Stephen Hemminger
2023-01-22 20:51 ` Thomas Monjalon
2023-02-06 16:01 ` Sinan Kaya [this message]
2023-02-06 18:46 ` Thomas Monjalon
2023-02-06 16:00 ` [PATCH v3 00/10] codeql fixes for various subsystems Sinan Kaya
2023-07-06 22:43 ` Stephen Hemminger
2023-07-10 15:18 ` Sinan Kaya
2023-07-10 17:07 ` [PATCH v4 0/5] fixes for problems found by codeql analyzer Stephen Hemminger
2023-07-10 17:07 ` [PATCH v4 1/5] mailmap: add Sinan Stephen Hemminger
2023-07-10 17:07 ` [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get Stephen Hemminger
2023-12-16 10:06 ` Andrew Rybchenko
2023-12-16 10:08 ` Andrew Rybchenko
2023-07-10 17:07 ` [PATCH v4 3/5] memzone: check result of rte_fbarray_get and malloc_elem_from_data Stephen Hemminger
2023-07-10 17:07 ` [PATCH v4 4/5] malloc: codeql fixes Stephen Hemminger
2023-07-10 17:08 ` [PATCH v4 5/5] bus/vdev: check result of rte_vdev_device_name Stephen Hemminger
2023-12-16 10:10 ` Andrew Rybchenko
2023-07-11 1:37 ` [PATCH v4 0/5] fixes for problems found by codeql analyzer fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a8e9a64dc676fdd5da3b0cf39a8e34e83dac70.camel@kernel.org \
--to=okaya@kernel.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).