From: Ferruh Yigit <ferruh.yigit@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] net/enic: fix TSO for packets greater than 9208 bytes
Date: Thu, 2 Nov 2017 11:35:35 -0700 [thread overview]
Message-ID: <e25087f9-274c-9e5f-8071-1f535f890f60@intel.com> (raw)
In-Reply-To: <20171102054710.25010-1-johndale@cisco.com>
On 11/1/2017 10:47 PM, John Daley wrote:
> A check was previously added to drop Tx packets greater than what the Nic
> is capable of sending since such packets can freeze the send queue. The
> check did not account for TSO packets however, so TSO was limited to 9208
> bytes.
>
> Check packet length only for non-TSO packets. Also insure that TSO packet
> segment size plus the headers do not exceed what the Nic is capable of
> since this also can freeze the send queue.
>
> Use the PKT_TX_TCP_SEG ol_flag instead of m->tso_segsz which is the
> preferred way to check for TSO.
>
> Fixes: ed6e564c214e ("net/enic: fix memory leak with oversized Tx packets")
> Cc: stable@dpdk.org
>
> Signed-off-by: John Daley <johndale@cisco.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-11-02 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 1:59 [dpdk-stable] [PATCH] " John Daley
2017-11-02 5:47 ` [dpdk-stable] [PATCH v2] " John Daley
2017-11-02 18:35 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25087f9-274c-9e5f-8071-1f535f890f60@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).