From: Eelco Chaudron <echaudro@redhat.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vfio: add hotplug support
Date: Fri, 17 Mar 2017 12:07:18 +0100 [thread overview]
Message-ID: <e274a848-2cfe-3438-8a6f-e96343e6012b@redhat.com> (raw)
In-Reply-To: <1489661496-12818-1-git-send-email-alejandro.lucero@netronome.com>
On 16/03/17 11:51, Alejandro Lucero wrote:
> Current device hotplug is just when using UIO. This patch adds
> same functionality with VFIO.
>
> It has been validated through tests using IOMMU and also with VFIO
> and no-iommu mode.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
> lib/librte_eal/common/eal_common_pci.c | 2 +-
> lib/librte_eal/linuxapp/eal/eal_pci.c | 5 +-
> lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 +
> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 82 ++++++++++-
> lib/librte_eal/linuxapp/eal/eal_vfio.c | 193 +++++++++++++++++++------
> lib/librte_eal/linuxapp/eal/eal_vfio.h | 11 +-
> lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 23 ++-
> lib/librte_ether/rte_ethdev.c | 2 +-
> 8 files changed, 263 insertions(+), 56 deletions(-)
Thanks Alex for providing this patch to add the VFIO hotplug
functionality, and to incorporate my offline review comments.
I also tested this patch in combination with Open vSwitch 2.70's hotplug
feature and did not see any problems.
//Eelco
Reviewed-by: Eelco Chaudron <echaudro@redhat.com>
Tested-by: Eelco Chaudron <echaudro@redhat.com>
next prev parent reply other threads:[~2017-03-17 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 10:51 Alejandro Lucero
2017-03-17 11:07 ` Eelco Chaudron [this message]
2017-03-22 13:49 ` Burakov, Anatoly
2017-03-23 12:08 ` Burakov, Anatoly
2017-03-24 16:39 ` Alejandro Lucero
2017-03-24 16:38 ` Alejandro Lucero
2017-03-24 16:56 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e274a848-2cfe-3438-8a6f-e96343e6012b@redhat.com \
--to=echaudro@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).