From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>,
Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Cc: "shafafs@mellanox.com" <shafafs@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 8/8] ipc: fix net/mlx5 memleak
Date: Tue, 23 Apr 2019 09:09:10 +0100 [thread overview]
Message-ID: <e2ef8184-4cf6-b930-aaf5-a5351b51c6a4@intel.com> (raw)
In-Reply-To: <CB3736B6-914C-40E9-A6A3-8CA8E3C61F59@mellanox.com>
On 22-Apr-19 6:51 PM, Yongseok Koh wrote:
>
>> On Apr 17, 2019, at 7:44 AM, Herakliusz Lipiec <herakliusz.lipiec@intel.com> wrote:
>>
>> When sending multiple requests, rte_mp_request_sync
>> can succeed sending a few of those requests, but then
>> fail on a later one and in the end return with rc=-1.
>> The upper layers - e.g. device hotplug - currently
>> handles this case as if no messages were sent and no
>> memory for response buffers was allocated, which is
>> not true. Fixed by always freeing reply message buffers.
>>
>> Fixes: 9a8ab29b84d3 ("net/mlx5: replace IPC socket with EAL API")
>> Fixes: c18cf501a7af ("net/mlx5: enable secondary process to register DMA memory")
>> Cc: yskoh@mellanox.com
>> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
>> ---
>> drivers/net/mlx5/mlx5_mp.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/mlx5/mlx5_mp.c b/drivers/net/mlx5/mlx5_mp.c
>> index cea74adb6..c9915b1d5 100644
>> --- a/drivers/net/mlx5/mlx5_mp.c
>> +++ b/drivers/net/mlx5/mlx5_mp.c
>> @@ -258,6 +258,7 @@ mlx5_mp_req_mr_create(struct rte_eth_dev *dev, uintptr_t addr)
>> if (ret) {
>> DRV_LOG(ERR, "port %u request to primary process failed",
>> dev->data->port_id);
>> + free(mp_rep.msgs);
>> return -rte_errno;
>> }
>> assert(mp_rep.nb_received == 1);
>> @@ -295,7 +296,8 @@ mlx5_mp_req_verbs_cmd_fd(struct rte_eth_dev *dev)
>> if (ret) {
>> DRV_LOG(ERR, "port %u request to primary process failed",
>> dev->data->port_id);
>> - return -rte_errno;
>> + ret = -rte_errno;
>> + goto exit;
>
> These two requests will be made by a secondary process targeting to the primary.
> Then, there's only one request in this case and we don't need to take care of that.
> Right?
>
> Same comment for mlx4.
Hi Yongseok,
mp_rep.msgs is potentially allocated regardless of whether you're in
primary or secondary, and whether the call to mp_request_sync succeeded
or failed. Hence, need to free in all cases.
See this patch: http://patches.dpdk.org/patch/52868/
and this bug: https://bugs.dpdk.org/show_bug.cgi?id=228
>
> Thanks,
> Yongseok
>
>> }
>> assert(mp_rep.nb_received == 1);
>> mp_res = &mp_rep.msgs[0];
>> --
>> 2.17.2
>>
>
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-04-23 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:44 Herakliusz Lipiec
2019-04-17 14:44 ` Herakliusz Lipiec
2019-04-22 17:51 ` Yongseok Koh
2019-04-22 17:51 ` Yongseok Koh
2019-04-23 8:09 ` Burakov, Anatoly [this message]
2019-04-23 8:09 ` Burakov, Anatoly
2019-04-23 20:13 ` Yongseok Koh
2019-04-23 20:13 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ef8184-4cf6-b930-aaf5-a5351b51c6a4@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=shafafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).