From: Andy Green <andy@warmcat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 15/23] rte_ethdev.h: align sign and scope of temp var
Date: Thu, 17 May 2018 22:17:04 +0800 [thread overview]
Message-ID: <e31c7149-1a22-f305-faa3-56865a5603a1@warmcat.com> (raw)
In-Reply-To: <20180517135417.GB22288@bricha3-MOBL.ger.corp.intel.com>
On 05/17/2018 09:54 PM, Bruce Richardson wrote:
> On Mon, May 14, 2018 at 01:10:43PM +0800, Andy Green wrote:
>> Signed-off-by: Andy Green <andy@warmcat.com>
>> ---
>> lib/librte_ethdev/rte_ethdev.h | 25 +++++++++++++++----------
>> 1 file changed, 15 insertions(+), 10 deletions(-)
>>
>
> While I dislike the changes below, since I believe it's always more
> readable to declare variables at first use, if the changes are needed to
> remove compiler errors in apps, then they need to be fixed.
>
> Patch needs a suitable commit log explaining the changes or giving the
> error message.
It has this in the last push (which overlapped with your comment)... I
seem to have missed the error about declarations after code not being
allowed in C90, but I guess that part being an issue is not controversial.
>
>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
>> index 49c2ebbd5..2cb5fe3be 100644
>> --- a/lib/librte_ethdev/rte_ethdev.h
>> +++ b/lib/librte_ethdev/rte_ethdev.h
>> @@ -3801,6 +3801,7 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t queue_id,
>> struct rte_mbuf **rx_pkts, const uint16_t nb_pkts)
>> {
>> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
>> + uint16_t nb_rx;
>>
>> #ifdef RTE_LIBRTE_ETHDEV_DEBUG
>> RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
>> @@ -3811,18 +3812,22 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t queue_id,
>> return 0;
>> }
>> #endif
>> - int16_t nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
>> - rx_pkts, nb_pkts);
>> + nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
>> + rx_pkts, nb_pkts);
>>
>> #ifdef RTE_ETHDEV_RXTX_CALLBACKS
>> - struct rte_eth_rxtx_callback *cb = dev->post_rx_burst_cbs[queue_id];
>> -
>> - if (unlikely(cb != NULL)) {
>> - do {
>> - nb_rx = cb->fn.rx(port_id, queue_id, rx_pkts, nb_rx,
>> - nb_pkts, cb->param);
>> - cb = cb->next;
>> - } while (cb != NULL);
>> + {
>> + struct rte_eth_rxtx_callback *cb =
>> + dev->post_rx_burst_cbs[queue_id];
>> +
>> + if (unlikely(cb != NULL)) {
>> + do {
>> + nb_rx = cb->fn.rx(port_id, queue_id,
>> + rx_pkts, nb_rx,
>> + nb_pkts, cb->param);
>> + cb = cb->next;
>> + } while (cb != NULL);
>> + }
>> }
>> #endif
>
> Rather than increasing the level of indentation needed with the extra
> braces, it's probably best to separate variable definition and assignment
> as you did in the first change above.
IIRC my thinking was I had a choice to repeat the conditional
compilation stuff around the declaration (because it's in an #ifdef),
(void)cb; to dodge the unused var warning, or add a basic block for it
to scope to. The last one didn't seem so bad.
-Andy
> /Bruce
>
next prev parent reply other threads:[~2018-05-17 14:17 UTC|newest]
Thread overview: 174+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:58 [dpdk-dev] [PATCH v3 00/24] Fixes for GCC8 against lagopus Andy Green
2018-05-12 1:58 ` [dpdk-dev] [PATCH v3 01/24] lib/librte_eal: import libbsd strlcpy Andy Green
2018-05-13 14:56 ` Thomas Monjalon
2018-05-13 23:07 ` Andy Green
2018-05-12 1:58 ` [dpdk-dev] [PATCH v3 02/24] lib/librte_ethdev: change eth-dev-ops API to return int Andy Green
2018-05-13 14:58 ` Thomas Monjalon
2018-05-13 23:10 ` Andy Green
2018-05-13 23:49 ` Thomas Monjalon
2018-05-12 1:58 ` [dpdk-dev] [PATCH v3 03/24] rte_common.h: cast gcc builtin result to avoid complaints Andy Green
2018-05-13 20:40 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 04/24] lib/librte_eal: explicit tmp cast Andy Green
2018-05-13 16:19 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 05/24] lib/librte_eal: explicit cast for signed change Andy Green
2018-05-13 20:40 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 06/24] /lib/librte_eal: stage cast from uint64 to long Andy Green
2018-05-13 16:24 ` Thomas Monjalon
2018-05-13 23:17 ` Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 07/24] rte_spinlock.h: stack declarations before code Andy Green
2018-05-13 20:42 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: " Andy Green
2018-05-13 16:47 ` Thomas Monjalon
2018-05-13 23:21 ` Andy Green
2018-05-13 23:44 ` Thomas Monjalon
2018-05-14 0:09 ` Andy Green
2018-05-14 1:49 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 09/24] rte_ring.h: remove signed type flipflopping Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 10/24] rte_dev.h: stack declaration at top of own basic block Andy Green
2018-05-13 20:41 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 11/24] rte_mbuf.h: avoid warnings from inadvertant promotion Andy Green
2018-05-13 16:54 ` Thomas Monjalon
2018-05-13 23:27 ` Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 12/24] rte_mbuf.h: explicit casts for int16 to uint16 Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 13/24] rte_mbuf.h: make sure RTE-MIN compares same types Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 14/24] rte_mbuf.h: explicit cast restricting ptrdiff to uint16 Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 15/24] rte_mbuf.h: explicit cast for size type to uint32 Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 16/24] rte_mbuf.h: explicit casts to uint16 to avoid warnings Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 17/24] rte_byteorder.h: explicit cast for return promotion Andy Green
2018-05-13 16:59 ` Thomas Monjalon
2018-05-14 0:02 ` Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 18/24] rte_ether.h: explicit cast avoiding truncation warning Andy Green
2018-05-13 17:02 ` Thomas Monjalon
2018-05-14 0:05 ` Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 19/24] rte_ether.h: stack vars declared at top of function Andy Green
2018-05-13 20:42 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 20/24] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 21/24] rte_ethdev.h: explicit cast for truncation Andy Green
2018-05-13 20:43 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 22/24] rte_hash_crc.h: stack vars declared at top of function Andy Green
2018-05-13 20:44 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 23/24] rte_hash_crc.h: explicit casts for truncation Andy Green
2018-05-13 20:44 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 24/24] test_table_pipeline: repair munged indirection level Andy Green
2018-05-13 20:33 ` Thomas Monjalon
2018-05-14 0:22 ` Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 00/23] Fixes for GCC8 against lagopus Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 01/23] lib/librte_eal: import libbsd strlcpy Andy Green
2018-05-17 10:36 ` Bruce Richardson
2018-05-17 12:35 ` Andy Green
2018-05-17 12:56 ` Bruce Richardson
2018-05-17 13:00 ` Andy Green
2018-05-17 13:49 ` Bruce Richardson
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 02/23] rte_eal_version_map: export rte-strlcpy Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 03/23] lib/librte_ethdev: change eth-dev-ops API to return int Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 04/23] lib/librte_eal: explicit tmp cast Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 05/23] /lib/librte_eal: stage cast from uint64 to long Andy Green
2018-05-17 10:47 ` Bruce Richardson
2018-05-17 12:56 ` Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 06/23] rte_ring_generic.h: stack declarations before code Andy Green
2018-05-17 8:29 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 07/23] rte_ring.h: remove signed type flipflopping Andy Green
2018-05-17 8:29 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 08/23] rte_mbuf.h: avoid warnings from inadvertant promotion Andy Green
2018-05-17 8:30 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 09/23] rte_mbuf.h: explicit casts for int16 to uint16 Andy Green
2018-05-17 8:30 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 10/23] rte_mbuf.h: make sure RTE-MIN compares same types Andy Green
2018-05-17 10:49 ` Bruce Richardson
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 11/23] rte_mbuf.h: explicit cast restricting ptrdiff to uint16 Andy Green
2018-05-17 10:50 ` Bruce Richardson
2018-05-17 11:03 ` Ananyev, Konstantin
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 12/23] rte_mbuf.h: explicit cast for size type to uint32 Andy Green
2018-05-17 10:53 ` Bruce Richardson
2018-05-17 13:09 ` Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 13/23] rte_mbuf.h: explicit casts to uint16 to avoid warnings Andy Green
2018-05-17 10:58 ` Bruce Richardson
2018-05-17 13:28 ` Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 14/23] rte_ether.h: explicit cast avoiding truncation warning Andy Green
2018-05-17 11:01 ` Bruce Richardson
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 15/23] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-17 13:54 ` Bruce Richardson
2018-05-17 14:17 ` Andy Green [this message]
2018-05-17 14:26 ` Bruce Richardson
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 16/23] rte_byteorder.h: explicit cast for return promotion Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 17/23] test_table_pipeline: repair munged indirection level Andy Green
2018-05-14 10:35 ` Singh, Jasvinder
2018-05-14 10:46 ` Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 18/23] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 19/23] rte_ip.h: cast input to bswap16 to be uint16 Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 20/23] rte_ip.h: cast around promotion to int Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 21/23] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 22/23] rte_ip.h: cast return checksum size to uint16 Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 23/23] rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum Andy Green
2018-05-17 13:48 ` [dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus Andy Green
2018-05-17 13:48 ` [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev-ops API to return int Andy Green
2018-05-17 13:55 ` Bruce Richardson
2018-05-17 13:59 ` Andy Green
2018-05-18 10:59 ` Shreyansh Jain
2018-05-18 11:12 ` Andy Green
2018-05-20 2:43 ` Shreyansh Jain
2018-05-20 4:11 ` Andy Green
2018-05-21 6:52 ` Stephen Hemminger
2018-05-21 7:25 ` Andy Green
2018-05-18 13:02 ` [dpdk-dev] [PATCH] rte_ethdev.h: fix gcc8.1 sign conversion warining Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 02/21] rte_string_fns.h: fix gcc8.1 sign conv warning in lstrcpy Andy Green
2018-05-17 13:56 ` Bruce Richardson
2018-05-17 14:03 ` [dpdk-dev] [PATCH] " Andy Green
2018-05-17 14:40 ` [dpdk-dev] [PATCH v5 02/21] " Stephen Hemminger
2018-05-17 15:28 ` Bruce Richardson
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 03/21] lib/librte_eal: explicit tmp cast Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 04/21] /lib/librte_eal: stage cast from uint64 to long Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 05/21] rte_ring_generic.h: stack declarations before code Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 06/21] rte_ring.h: remove signed type flipflopping Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 07/21] rte_mbuf.h: avoid warnings from inadvertant promotion Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 08/21] rte_mbuf.h: explicit casts for int16 to uint16 Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 09/21] rte_mbuf.h: make sure RTE-MIN compares same types Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 10/21] rte_mbuf.h: explicit cast restricting ptrdiff to uint16 Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 11/21] rte_ether.h: explicit cast avoiding truncation warning Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 12/21] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 13/21] rte_ip.h: cast input to bswap16 to be uint16 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 14/21] rte_ip.h: cast around promotion to int Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 15/21] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 16/21] rte_ip.h: cast return checksum size to uint16 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 17/21] rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 18/21] rte_mbuf.h: explicit cast for size type to uint32 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 19/21] rte_mbuf.h: explicit casts to uint16 to avoid warnings Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 20/21] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 21/21] rte_byteorder.h: explicit cast for return promotion Andy Green
2018-05-20 22:18 ` [dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus Thomas Monjalon
2018-05-21 2:00 ` [dpdk-dev] [PATCH v6 0/8] " Andy Green
2018-05-21 2:00 ` [dpdk-dev] [PATCH v6 1/8] lib/librte_eal: explicit tmp cast Andy Green
2018-05-21 11:06 ` [dpdk-dev] [PATCH] lib/librte_eal: change type of tmp Andy Green
2018-05-21 12:07 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 2/8] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-21 12:10 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 3/8] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-21 12:13 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 4/8] rte_mbuf.h: reduce temp to match uint16 types Andy Green
2018-05-21 12:14 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 5/8] rte_mbuf.h: avoid implicit demotion in 64-bit arith Andy Green
2018-05-21 12:27 ` Bruce Richardson
2018-05-22 1:29 ` Andy Green
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 6/8] rte_mbuf.h: choose correct type for temp Andy Green
2018-05-21 13:09 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 7/8] rte_mbuf.h: add and subtract explicitly to avoid promotion Andy Green
2018-05-21 13:10 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 8/8] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-21 13:30 ` Bruce Richardson
2018-05-22 1:25 ` Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 0/8] Fixes for GCC8 against lagopus Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 1/8] lib/librte_eal: change type of tmp Andy Green
2018-05-22 9:13 ` Bruce Richardson
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 2/8] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 3/8] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 4/8] rte_mbuf.h: reduce temp to match uint16 types Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 5/8] rte_mbuf.h: avoid implicit demotion in 64-bit arith Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 6/8] rte_mbuf.h: choose correct type for temp Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 7/8] rte_mbuf.h: add and subtract explicitly to avoid promotion Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 8/8] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-22 9:12 ` Bruce Richardson
2018-05-22 14:18 ` Thomas Monjalon
2018-05-22 9:13 ` [dpdk-dev] [PATCH v7 0/8] Fixes for GCC8 against lagopus Bruce Richardson
2018-05-22 9:14 ` Andy Green
2018-05-22 14:29 ` Thomas Monjalon
2018-05-21 2:06 ` [dpdk-dev] [PATCH v5 00/21] " Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e31c7149-1a22-f305-faa3-56865a5603a1@warmcat.com \
--to=andy@warmcat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).