From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: jianfeng.tan@intel.com, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH 3/6] eal: remove log level from internal config
Date: Tue, 18 Apr 2017 16:00:45 +0100 [thread overview]
Message-ID: <e3677a93-257d-ba78-10b0-5573ca3a86bd@intel.com> (raw)
In-Reply-To: <20170418142225.6308-3-olivier.matz@6wind.com>
On 4/18/2017 3:22 PM, Olivier Matz wrote:
> This field is only used in the initialization phase. Remove it since the
> global log level can also be retrieved using a public API:
> rte_log_get_global_level().
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
<...>
> diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> index dd4d30ca7..7d13cc026 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -244,6 +244,12 @@ RTE_INIT(rte_log_init);
> static void
> rte_log_init(void)
> {
> +#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
Why ">=" (I aware previous one is also like this :), setting global
config option to RTE_LOG_DEBUG cause a INFO level log...
> + rte_log_set_global_level(RTE_LOG_INFO);
> +#else
> + rte_log_set_global_level(RTE_LOG_LEVEL);
> +#endif
next prev parent reply other threads:[~2017-04-18 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 14:22 [dpdk-dev] [PATCH 1/6] eal: fix default log level Olivier Matz
2017-04-18 14:22 ` [dpdk-dev] [PATCH 2/6] eal: move internal config initialization Olivier Matz
2017-04-18 14:22 ` [dpdk-dev] [PATCH 3/6] eal: remove log level from internal config Olivier Matz
2017-04-18 15:00 ` Ferruh Yigit [this message]
2017-04-18 15:26 ` Olivier MATZ
2017-04-18 15:28 ` Ferruh Yigit
2017-04-18 14:22 ` [dpdk-dev] [PATCH 4/6] eal: remove undue printf Olivier Matz
2017-04-18 14:22 ` [dpdk-dev] [PATCH 5/6] eal: fix log level regexp matching Olivier Matz
2017-04-18 14:22 ` [dpdk-dev] [PATCH 6/6] eal: fix dump of registered logs when disabled Olivier Matz
2017-04-18 15:29 ` [dpdk-dev] [PATCH 1/6] eal: fix default log level Ferruh Yigit
2017-04-19 23:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3677a93-257d-ba78-10b0-5573ca3a86bd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).