From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 00/15] common linkstatus functions
Date: Thu, 25 Jan 2018 13:51:19 +0000 [thread overview]
Message-ID: <e3704c5b-0ac5-829c-c349-6fb908a01a2f@intel.com> (raw)
In-Reply-To: <20180122235458.28562-1-stephen@networkplumber.org>
On 1/22/2018 11:54 PM, Stephen Hemminger wrote:
> While reviewing drivers, noticed a lot of unnecessary
> duplication of code in drivers for handling the eth_dev link status
> information. While consolidating this, it also became obvious that
> some drivers behave differently for no good reason.
>
> It also was a good chance to introduce atomic exchange primitives
> in EAL because there are other places using cmpset where not
> necessary (such as bonding).
>
> Mostly only compile tested only, don't have all of the hardware
> available (except ixgbe and virtio) to test.
>
>
> v7
> - add exchange functions for PPC64
> - move linkstatus helpers to rte_ethdev_driver
> - rebase to 18.02
>
>
>
> Stephen Hemminger (15):
> eal: introduce atomic exchange operation
> ethdev: add linkstatus get/set helper functions
> net/virtio: use eth_linkstatus_set
> net/vmxnet3: use rte_eth_linkstatus_set
> net/dpaa2: use rte_eth_linkstatus_set
> net/nfp: use rte_eth_linkstatus functions
> net/e1000: use rte_eth_linkstatus helpers
> net/ixgbe: use rte_eth_linkstatus functions
> net/sfc: use new rte_eth_linkstatus functions
> net/i40e: use rte_eth_linkstatus functions
> net/liquidio: use rte_eth_linkstatus_set
> net/thunderx: use rte_eth_linkstatus_set
> net/szedata: use _rte_eth_linkstatus_set
> net/octeontx: use rte_eth_linkstatus_set
> net/enic: use rte_eth_linkstatus_set
This patchset is not able to make rc1, I am for postponing it to next release
instead of getting in later rc.
It is good to have eal atomic exchange APIs and it is good that some duplicated
code removed from APIs but I think it would be better to discuss and have a
consensus on what dev_link_update() function should return, and get some acks
from PMD maintainers first.
What do you think?
prev parent reply other threads:[~2018-01-25 13:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 23:54 Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-23 0:07 ` [dpdk-dev] [PACH v7 02a] typo in i686 version of rte_atomic64_exchange Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 05/15] net/dpaa2: " Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-23 12:27 ` Neil Horman
2018-01-25 13:45 ` Ferruh Yigit
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 09/15] net/sfc: use new " Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 10/15] net/i40e: use " Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 11/15] net/liquidio: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 12/15] net/thunderx: " Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 13/15] net/szedata: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-22 23:54 ` [dpdk-dev] [PATCH v7 15/15] net/enic: " Stephen Hemminger
2018-01-25 13:51 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3704c5b-0ac5-829c-c349-6fb908a01a2f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).