From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Vargas, Hernan" <hernan.vargas@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"Rix, Tom" <trix@redhat.com>
Cc: "Chautru, Nicolas" <nicolas.chautru@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set
Date: Mon, 20 Feb 2023 16:38:57 +0100 [thread overview]
Message-ID: <e3de7a79-0721-420e-7293-57b81c0f6bfb@redhat.com> (raw)
In-Reply-To: <DM6PR11MB36600C87BEC53E63E12DC0C6EFDE9@DM6PR11MB3660.namprd11.prod.outlook.com>
On 2/10/23 18:15, Vargas, Hernan wrote:
> Hi Maxime,
>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, January 31, 2023 4:04 AM
> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org; gakhil@marvell.com; Rix, Tom <trix@redhat.com>
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set
>
>
>
> On 1/17/23 17:50, Hernan Vargas wrote:
>> Early termination needs to be explicitly enabled.
>>
>> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
>> ---
>> app/test-bbdev/test_bbdev_perf.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
>> index 14fe76eb64..12fa988da6 100644
>> --- a/app/test-bbdev/test_bbdev_perf.c
>> +++ b/app/test-bbdev/test_bbdev_perf.c
>> @@ -4463,7 +4463,7 @@ latency_test_dec(struct rte_mempool *mempool,
>> struct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op,
>> int vector_mask, uint16_t dev_id, uint16_t queue_id,
>> const uint16_t num_to_process, uint16_t burst_sz,
>> - uint64_t *total_time, uint64_t *min_time, uint64_t *max_time)
>> + uint64_t *total_time, uint64_t *min_time, uint64_t *max_time, bool disable_et)
>> {
>> int ret = TEST_SUCCESS;
>> uint16_t i, j, dequeued;
>> @@ -4481,6 +4481,13 @@ latency_test_dec(struct rte_mempool *mempool,
>> ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);
>> TEST_ASSERT_SUCCESS(ret,
>> "rte_bbdev_dec_op_alloc_bulk() failed");
>> + ref_op->turbo_dec.iter_max = get_iter_max();
>> + /* For validation tests we want to enable early termination */
>> + if (!disable_et && !check_bit(ref_op->turbo_dec.op_flags,
>> + RTE_BBDEV_TURBO_EARLY_TERMINATION))
>> + ref_op->turbo_dec.op_flags |=
>> + RTE_BBDEV_TURBO_EARLY_TERMINATION;
>> +
>> if (test_vector.op_type != RTE_BBDEV_OP_NONE)
>> copy_reference_dec_op(ops_enq, burst_sz, dequeued,
>> bufs->inputs,
>> @@ -4873,7 +4880,7 @@ validation_latency_test(struct active_device *ad,
>> iter = latency_test_dec(op_params->mp, bufs,
>> op_params->ref_dec_op, op_params->vector_mask,
>> ad->dev_id, queue_id, num_to_process,
>> - burst_sz, &total_time, &min_time, &max_time);
>> + burst_sz, &total_time, &min_time, &max_time, latency_flag);
>> else if (op_type == RTE_BBDEV_OP_LDPC_ENC)
>> iter = latency_test_ldpc_enc(op_params->mp, bufs,
>> op_params->ref_enc_op, ad->dev_id, queue_id,
>
> Not clear to me whether it should be a fix. Any thoughts?
>
> Thanks,
> Maxime
>
> This is not a fix, it's just an enhancement to enable early termination for validation tests if the device supports it.
> The validation tests currently run iter_max number of iterations for decoding, with this enhancement the decoding could terminate early.
>
> Thanks,
> Hernan
Could you please fix your email client?
The message you are replying to is not quoted.
Thanks,
Maxime
next prev parent reply other threads:[~2023-02-20 15:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:50 [PATCH v1 00/13] test/bbdev: changes for 23.03 Hernan Vargas
2023-01-17 16:50 ` [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas
2023-01-31 9:20 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 02/13] test/bbdev: refactor TB throughput report Hernan Vargas
2023-01-31 9:48 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 03/13] test/bbdev: add timeout for latency tests Hernan Vargas
2023-01-31 10:02 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 04/13] test/bbdev: early termination not explicit set Hernan Vargas
2023-01-31 10:04 ` Maxime Coquelin
2023-02-10 17:15 ` Vargas, Hernan
2023-02-20 15:38 ` Maxime Coquelin [this message]
2023-01-17 16:50 ` [PATCH v1 05/13] test/bbdev: report device status in bbdev-test Hernan Vargas
2023-01-31 10:05 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 06/13] test/bbdev: log capture from queue stop Hernan Vargas
2023-01-31 10:07 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 07/13] test/bbdev: add support for BLER for 4G Hernan Vargas
2023-01-31 10:20 ` Maxime Coquelin
2023-02-13 20:59 ` Vargas, Hernan
2023-02-20 15:43 ` Maxime Coquelin
2023-02-22 21:55 ` Vargas, Hernan
2023-02-23 8:26 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 08/13] test/bbdev: extend support for large TB Hernan Vargas
2023-01-31 11:29 ` Maxime Coquelin
2023-02-13 20:20 ` Vargas, Hernan
2023-02-20 15:40 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some scenarios Hernan Vargas
2023-01-31 12:15 ` Maxime Coquelin
2023-02-13 19:40 ` Chautru, Nicolas
2023-01-17 16:50 ` [PATCH v1 10/13] test/bbdev: adjustment for soft output Hernan Vargas
2023-01-31 12:25 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 11/13] test/bbdev: expose warning counters Hernan Vargas
2023-01-31 12:26 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 12/13] test/bbdev: remove check for invalid opaque data Hernan Vargas
2023-01-31 12:33 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 13/13] test/bbdev: remove iteration count check Hernan Vargas
2023-01-31 12:35 ` Maxime Coquelin
2023-02-08 20:38 ` Vargas, Hernan
2023-02-09 9:10 ` Maxime Coquelin
2023-02-09 16:59 ` Chautru, Nicolas
2023-02-10 14:01 ` Maxime Coquelin
2023-02-10 18:11 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3de7a79-0721-420e-7293-57b81c0f6bfb@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).