From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>,
Tianli Lai <laitianli@tom.com>,
dev@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Subject: Re: [PATCH] net/dpaa2: change threshold value
Date: Fri, 9 Jun 2023 15:20:30 +0100 [thread overview]
Message-ID: <e512e60a-6c87-b4d5-867f-23e222d42dfb@amd.com> (raw)
In-Reply-To: <eba9a379-ab6f-6b51-f012-08c3d306d7db@oss.nxp.com>
On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote:
> On 5/8/2023 4:11 PM, Tianli Lai wrote:
>> Caution: This is an external email. Please take care when clicking
>> links or opening attachments. When in doubt, report the message using
>> the 'Report this email' button
>>
>>
>> this threshold value can be changed with function argument nb_rx_desc.
>>
>> Signed-off-by: Tianli Lai <laitianli@tom.com>
>> ---
>> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c
>> b/drivers/net/dpaa2/dpaa2_ethdev.c
>> index 679f33ae1a..ad892ded4a 100644
>> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
>> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
>> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
>> dpaa2_q->cgid,
>> &taildrop);
>> } else {
>> /*enabling per rx queue congestion control */
>> - taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q;
>> + taildrop.threshold = nb_rx_desc * 1024;
>> taildrop.units = DPNI_CONGESTION_UNIT_BYTES;
>> taildrop.oal = CONG_RX_OAL;
>> DPAA2_PMD_DEBUG("Enabling Byte based Drop on
>> queue= %d",
>> --
>> 2.27.0
>>
> Hi Tianli,
>
> The number of bytes based tail drop threshold value
> "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we
> concluded this value after multiple benchmark experiments in past.
> Although, number of frame based threshold value is "nb_rx_desc" based only.
> We will further review this suggestion and get back.
>
Hi Sachin, What is the status of this patch?
next prev parent reply other threads:[~2023-06-09 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 10:41 Tianli Lai
2023-05-15 8:16 ` Sachin Saxena (OSS)
2023-06-09 14:20 ` Ferruh Yigit [this message]
2023-09-29 13:50 ` Ferruh Yigit
2023-11-02 21:06 ` Ferruh Yigit
2023-11-03 15:58 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e512e60a-6c87-b4d5-867f-23e222d42dfb@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=laitianli@tom.com \
--cc=sachin.saxena@nxp.com \
--cc=sachin.saxena@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).