From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jie Hai <haijie1@huawei.com>,
dev@dpdk.org, Yisen Zhuang <yisen.zhuang@huawei.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
Chunsong Feng <fengchunsong@huawei.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Cc: fengchengwen@huawei.com, liudongdong3@huawei.com
Subject: Re: [PATCH v2 5/6] net/hns3: refactor send mailbox function
Date: Fri, 10 Nov 2023 16:23:40 +0000 [thread overview]
Message-ID: <e5986fc0-b36f-419a-a8bb-dec21cc2309e@amd.com> (raw)
In-Reply-To: <20231110061331.3670158-6-haijie1@huawei.com>
On 11/10/2023 6:13 AM, Jie Hai wrote:
> From: Dengdui Huang <huangdengdui@huawei.com>
>
> The 'hns3_send_mbx_msg' function has following problem:
> 1. the name is vague, missing caller indication.
> 2. too many input parameters because the filling messages
> are placed in commands the send command.
>
> Therefore, a common interface is encapsulated to fill in
> the mailbox message before sending it.
>
> Fixes: 463e748964f5 ("net/hns3: support mailbox")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
<...>
> @@ -635,8 +642,8 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)
> rte_atomic_store_explicit(&vf->pf_push_lsc_cap, HNS3_PF_PUSH_LSC_CAP_UNKNOWN,
> rte_memory_order_release);
>
> - (void)hns3_send_mbx_msg(hw, HNS3_MBX_GET_LINK_STATUS, 0, NULL, 0, false,
> - NULL, 0);
> + hns3vf_mbx_setup(&req, HNS3_MBX_GET_LINK_STATUS, 0);
> + (void)hns3vf_mbx_send(hw, &req, false, NULL, 0);
>
'req' is not declared in this function scope but used.
next prev parent reply other threads:[~2023-11-10 16:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 3:44 [PATCH 0/5] net/hns3: fix and refactor mailbox code Jie Hai
2023-11-08 3:44 ` [PATCH 1/5] net/hns3: fix sync mailbox failure forever Jie Hai
2023-11-08 3:44 ` [PATCH 2/5] net/hns3: refactor VF mailbox message struct Jie Hai
2023-11-09 18:51 ` Ferruh Yigit
2023-11-08 3:44 ` [PATCH 3/5] net/hns3: refactor PF " Jie Hai
2023-11-08 3:44 ` [PATCH 4/5] net/hns3: refactor send mailbox function Jie Hai
2023-11-08 3:44 ` [PATCH 5/5] net/hns3: refactor handle " Jie Hai
2023-11-09 18:50 ` [PATCH 0/5] net/hns3: fix and refactor mailbox code Ferruh Yigit
2023-11-10 6:21 ` Jie Hai
2023-11-10 12:35 ` Ferruh Yigit
2023-11-10 6:13 ` [PATCH v2 0/6] net/hns3: fix and refactor some codes Jie Hai
2023-11-10 6:13 ` [PATCH v2 1/6] net/hns3: fix sync mailbox failure forever Jie Hai
2023-11-10 6:13 ` [PATCH v2 2/6] net/hns3: use stdatomic API Jie Hai
2023-11-10 6:13 ` [PATCH v2 3/6] net/hns3: refactor VF mailbox message struct Jie Hai
2023-11-10 6:13 ` [PATCH v2 4/6] net/hns3: refactor PF " Jie Hai
2023-11-10 6:13 ` [PATCH v2 5/6] net/hns3: refactor send mailbox function Jie Hai
2023-11-10 16:23 ` Ferruh Yigit [this message]
2023-11-10 6:13 ` [PATCH v2 6/6] net/hns3: refactor handle " Jie Hai
2023-11-10 16:12 ` [PATCH v2 0/6] net/hns3: fix and refactor some codes Ferruh Yigit
2023-12-07 1:37 ` [PATCH v3 0/4] net/hns3: refactor mailbox Jie Hai
2023-12-07 1:37 ` [PATCH v3 1/4] net/hns3: refactor VF mailbox message struct Jie Hai
2023-12-07 12:47 ` Ferruh Yigit
2023-12-07 1:37 ` [PATCH v3 2/4] net/hns3: refactor PF " Jie Hai
2023-12-07 1:37 ` [PATCH v3 3/4] net/hns3: refactor send mailbox function Jie Hai
2023-12-07 1:37 ` [PATCH v3 4/4] net/hns3: refactor handle " Jie Hai
2023-12-07 12:31 ` [PATCH v3 0/4] net/hns3: refactor mailbox Ferruh Yigit
2023-12-08 1:06 ` Jie Hai
2023-12-08 6:55 ` [PATCH v4 " Jie Hai
2023-12-08 6:55 ` [PATCH v4 1/4] net/hns3: refactor VF mailbox message struct Jie Hai
2023-12-08 6:55 ` [PATCH v4 2/4] net/hns3: refactor PF " Jie Hai
2023-12-08 6:55 ` [PATCH v4 3/4] net/hns3: refactor send mailbox function Jie Hai
2023-12-08 6:55 ` [PATCH v4 4/4] net/hns3: refactor handle " Jie Hai
2023-12-08 10:48 ` [PATCH v4 0/4] net/hns3: refactor mailbox Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5986fc0-b36f-419a-a8bb-dec21cc2309e@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=fengchunsong@huawei.com \
--cc=ferruh.yigit@intel.com \
--cc=haijie1@huawei.com \
--cc=humin29@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=xavier.huwei@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).