From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Patrick Robb <probb@iol.unh.edu>, Chaoyong He <chaoyong.he@corigine.com>
Cc: dpdklab <dpdklab@iol.unh.edu>,
oss-drivers <oss-drivers@corigine.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 00/11] Add basic flow support for corenic firmware
Date: Tue, 7 Nov 2023 20:19:28 +0000 [thread overview]
Message-ID: <e64a2124-4436-4d6b-a69b-33ff95d41137@amd.com> (raw)
In-Reply-To: <CAJvnSUCHKN3Q5mKMx1Kb6TVe7t=73-j3pxqbQQ0D4TUT6ySFPA@mail.gmail.com>
On 11/7/2023 5:04 PM, Patrick Robb wrote:
> Sorry, now I understand what is causing confusion. When a retest is
> requested, that retest is done on the original dpdk artifact we created
> for the patchseries. We don't pull again, re-apply, and then rerun the
> testing. I think that is the behavior you were expecting, Ferruh.
>
Hi Patrick,
Thanks for clarification, yes that was my expectation.
> We have discussed whether this is an important option to support in
> future iterations of the retest-request feature. One idea is to add
> another option in the retest request schema which allows for the
> requester to indicate they want the patch re-applied onto the newer
> branch, and testing rerun with that new dpdk. It's good to see that this
> is a use case which would see application. Will be aiming to add this
> support in the future.
>
I am also not sure if this is the common usecase, lets record the need,
we can decide what to support based on it.
And as a generic approach, what about following syntax:
Recheck-request,attribute=value: ...
And for above case, attribute can be "pull=true" ...
next prev parent reply other threads:[~2023-11-07 20:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 6:25 Chaoyong He
2023-11-03 6:25 ` [PATCH 01/11] net/nfp: move some source files Chaoyong He
2023-11-03 6:25 ` [PATCH 02/11] drivers: add the structures and functions for flow offload Chaoyong He
2023-11-03 6:25 ` [PATCH 03/11] net/nfp: add the control message channel Chaoyong He
2023-11-03 6:25 ` [PATCH 04/11] net/nfp: support flow API for CoreNIC firmware Chaoyong He
2023-11-03 6:26 ` [PATCH 05/11] net/nfp: support Ethernet flow item Chaoyong He
2023-11-03 6:26 ` [PATCH 06/11] net/nfp: support drop flow action Chaoyong He
2023-11-03 6:26 ` [PATCH 07/11] net/nfp: support IPv4 flow item Chaoyong He
2023-11-03 6:26 ` [PATCH 08/11] net/nfp: support IPv6 " Chaoyong He
2023-11-03 6:26 ` [PATCH 09/11] net/nfp: support TCP/UDP/SCTP flow items Chaoyong He
2023-11-03 6:26 ` [PATCH 10/11] drivers: support MARK flow action Chaoyong He
2023-11-03 6:26 ` [PATCH 11/11] net/nfp: support QUEUE " Chaoyong He
2023-11-03 16:12 ` [PATCH 00/11] Add basic flow support for corenic firmware Ferruh Yigit
2023-11-07 1:42 ` Chaoyong He
2023-11-07 9:18 ` Ferruh Yigit
2023-11-07 9:23 ` Chaoyong He
2023-11-07 16:50 ` Patrick Robb
2023-11-07 17:04 ` Patrick Robb
2023-11-07 20:19 ` Ferruh Yigit [this message]
2023-11-07 21:59 ` Patrick Robb
2023-11-03 17:01 ` Ferruh Yigit
2023-12-05 2:54 ` [PATCH v2 " Chaoyong He
2023-12-05 2:54 ` [PATCH v2 01/11] net/nfp: move some source files Chaoyong He
2023-12-05 2:54 ` [PATCH v2 02/11] net/nfp: add the structures and functions for flow offload Chaoyong He
2023-12-05 2:54 ` [PATCH v2 03/11] net/nfp: add the control message channel Chaoyong He
2023-12-08 19:15 ` Ferruh Yigit
2023-12-05 2:54 ` [PATCH v2 04/11] net/nfp: support flow API for CoreNIC firmware Chaoyong He
2023-12-05 2:54 ` [PATCH v2 05/11] net/nfp: support Ethernet flow item Chaoyong He
2023-12-05 2:54 ` [PATCH v2 06/11] net/nfp: support drop flow action Chaoyong He
2023-12-05 2:54 ` [PATCH v2 07/11] net/nfp: support IPv4 flow item Chaoyong He
2023-12-05 2:54 ` [PATCH v2 08/11] net/nfp: support IPv6 " Chaoyong He
2023-12-05 2:54 ` [PATCH v2 09/11] net/nfp: support TCP/UDP/SCTP flow items Chaoyong He
2023-12-05 2:54 ` [PATCH v2 10/11] net/nfp: support MARK flow action Chaoyong He
2023-12-05 2:54 ` [PATCH v2 11/11] net/nfp: support QUEUE " Chaoyong He
2023-12-08 16:39 ` [PATCH v2 00/11] Add basic flow support for corenic firmware Ferruh Yigit
2023-12-11 1:42 ` Chaoyong He
2023-12-11 14:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e64a2124-4436-4d6b-a69b-33ff95d41137@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=oss-drivers@corigine.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).