From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add CL for ptype mapping configure
Date: Tue, 28 Mar 2017 13:28:56 +0100 [thread overview]
Message-ID: <e660dbc4-0328-6c00-0bf4-25f6dc7c055a@intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D17B9C@SHSMSX103.ccr.corp.intel.com>
On 3/28/2017 4:34 AM, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Friday, March 17, 2017 12:27 AM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
>> Zhang, Helin <helin.zhang@intel.com>
>> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add CL for ptype mapping
>> configure
>>
>> On 3/12/2017 12:08 PM, Qi Zhang wrote:
>>> Add below command line to configure ptype mapping.
>>> ptype mapping get <port_id> <valid_only>.
>>> ptype mapping replace <port_id> <target> <mask> <pkt_type>.
>>> ptype mapping reset <port_id>.
>>> ptype mapping update <port_id> <hw_ptype> <sw_ptype>.
>>>
>>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>>> ---
>>> app/test-pmd/cmdline.c | 372
>>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 372 insertions(+)
>>>
>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>>> 43fc636..85f07ba 100644
>>> --- a/app/test-pmd/cmdline.c
>>> +++ b/app/test-pmd/cmdline.c
>>> @@ -575,6 +575,18 @@ static void cmd_help_long_parsed(void
>> *parsed_result,
>>> "E-tag set filter del e-tag-id (value) port (port_id)\n"
>>> " Delete an E-tag forwarding filter on a port\n\n"
>>>
>>> + "ptype mapping get (port_id) (valid_only)\n"
>>> + " Get ptype mapping on a port\n\n"
>>> +
>>> + "ptype mapping replace (port_id) (target) (mask)
>> (pky_type)\n"
>>> + " Replace target with the pkt_type in ptype
>> mapping\n\n"
>>> +
>>> + "ptype mapping reset (port_id)\n"
>>> + " Reset ptype mapping on a port\n\n"
>>> +
>>> + "ptype mapping update (port_id) (hw_ptype)
>> (sw_ptype)\n"
>>> + " Update a ptype mapping item on a port\n\n"
>>> +
>>
>> This adds new root level "ptype" command, I think it would be nice to get an Ack
>> from testpmd maintainers for this.
>>
>> testpmd now supports many commands, and I don't know if it is only me, but I
>> am having hard time to find some commands. Perhaps commands can be
>> grouped better.
>
> Now following groups are used. I think the most confusing one
> is config or ports. Too many commands are included in it.
> But it looks like new group is not necessary for Qi's commands.
> We need extra work to refine it.
>
> "Help is available for the following sections:\n\n"
> " help control : Start and stop forwarding.\n"
> " help display : Displaying port, stats and config "
> "information.\n"
> " help config : Configuration information.\n"
> " help ports : Configuring ports.\n"
> " help registers : Reading and setting port registers.\n"
> " help filters : Filters configuration help.\n"
> " help all : All of the above sections.\n\n"
>
I don't know about new config group, but I was worried about new root
level config option, these mostly makes sense when you add, in limited
context, but can be hard to use them later, in whole application level.
If you are OK with new commands, as testpmd maintainer, I don't have any
objection.
Thanks,
ferruh
prev parent reply other threads:[~2017-03-28 12:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 4:56 [dpdk-dev] [PATCH 0/2] configurable PTYPE mapping Qi Zhang
2017-02-27 4:56 ` [dpdk-dev] [PATCH 1/2] net/i40e: enable per dev PTYPE mapping table Qi Zhang
2017-02-27 4:56 ` [dpdk-dev] [PATCH 2/2] net/i40e: configurable PTYPE mapping Qi Zhang
2017-03-06 15:32 ` Ferruh Yigit
2017-03-07 2:37 ` Zhang, Qi Z
2017-03-12 12:08 ` [dpdk-dev] [PATCH v2 0/3] " Qi Zhang
2017-03-12 12:08 ` [dpdk-dev] [PATCH v2 1/3] net/i40e: enable per dev PTYPE mapping table Qi Zhang
2017-03-12 12:08 ` [dpdk-dev] [PATCH v2 2/3] net/i40e: configurable PTYPE mapping Qi Zhang
2017-03-12 12:08 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: add CL for ptype mapping configure Qi Zhang
2017-03-16 16:27 ` Ferruh Yigit
2017-03-17 9:51 ` Zhang, Qi Z
2017-03-28 3:34 ` Wu, Jingjing
2017-03-28 12:28 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e660dbc4-0328-6c00-0bf4-25f6dc7c055a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).