From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org
Subject: [dpdk-stable] [PATCH v3 2/4] vfio: fix wrong return value for FreeBSD
Date: Thu, 28 Oct 2021 14:15:17 +0000 [thread overview]
Message-ID: <e6c78025127457557cbe19a0cd2a1f1ea325f047.1635430513.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635430513.git.anatoly.burakov@intel.com>
On FreeBSD, `rte_vfio_clear_group()` was returning 0 even though this
function is not valid for FreeBSD, and is called out to return error in
doxygen comments. Fix the return value to match documentation.
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/freebsd/eal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 9935356ed4..dada210b19 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -1032,7 +1032,7 @@ int rte_vfio_noiommu_is_enabled(void)
int rte_vfio_clear_group(__rte_unused int vfio_group_fd)
{
- return 0;
+ return -1;
}
int
--
2.25.1
next prev parent reply other threads:[~2021-10-28 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>
[not found] ` <b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com>
2021-10-28 13:49 ` [dpdk-stable] [PATCH v2 " Anatoly Burakov
2021-10-28 13:49 ` [dpdk-stable] [PATCH v2 3/4] vfio: fix documentation to match intended behavior Anatoly Burakov
[not found] ` <b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635430513.git.anatoly.burakov@intel.com>
2021-10-28 14:15 ` Anatoly Burakov [this message]
2021-11-05 2:50 ` [dpdk-stable] [dpdk-dev] [PATCH v3 2/4] vfio: fix wrong return value for FreeBSD Xia, Chenbo
2021-10-28 14:15 ` [dpdk-stable] [PATCH v3 3/4] vfio: fix documentation to match intended behavior Anatoly Burakov
2021-11-05 2:57 ` Xia, Chenbo
2021-10-28 14:15 ` [dpdk-stable] [PATCH v3 4/4] vfio: add errno on unsupported platforms Anatoly Burakov
2021-11-08 15:55 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6c78025127457557cbe19a0cd2a1f1ea325f047.1635430513.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).