From: Kevin Traynor <ktraynor@redhat.com>
To: David Marchand <david.marchand@redhat.com>,
Aaron Conole <aconole@redhat.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
David Hunt <david.hunt@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
jianfeng.tan@intel.com, Shahaf Shuler <shahafs@mellanox.com>,
alan.carew@intel.com, Liang Ma <liang.j.ma@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] lib: fix log typos
Date: Wed, 20 Nov 2019 13:29:05 +0000 [thread overview]
Message-ID: <e6e29e12-10ba-9fe0-b10f-d967bdee9ffa@redhat.com> (raw)
In-Reply-To: <CAJFAV8xh7qaqmXSkV8LcEBvKfVdF1bDhDzY+4Ry40o3Q9PL2Fw@mail.gmail.com>
On 20/11/2019 08:00, David Marchand wrote:
> On Tue, Nov 19, 2019 at 10:56 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>
>> On 19/11/2019 21:18, David Marchand wrote:
>>> On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>>>
>>>> Fix these as they are user visible. Found with codespell.
>>>>
>>>> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
>>>> Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
>>>> Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped")
>>>> Fixes: 445c6528b55f ("power: common interface for guest and host")
>>>> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>>>
>>> For the series,
>>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>>
>>> It would be nice to have codespell in devtools/checkpatches.sh.
>>>
>>
>> Voila!
>
> "Voilà !" :-)
>
>> https://git.dpdk.org/dpdk/commit/devtools/checkpatches.sh?id=abdd314151b304eeab08528555e884544151a2e4
>
> Arf, right.
>
>
>> Maybe we should add some doc to the contributors guide for it. It seems
>> to be run by one of the robots anyway.
>
> It is enabled by default.
>
Well, enabled by default if someone has the dictionary and set the
variable, so not really /that/ default.
Sent doc patch https://patchwork.dpdk.org/patch/63162/
> It does catch "informations".
>
> But it does not pick, for example, my typo on "preferrence" (no
> excuse, in French, it takes only one r too).
>
> Did you use https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary.txt
> ?
Yes, I used the latest upstream dictionary at the time.
> Not sure the robots are using the latest version.
>
>
> --
> David Marchand
>
prev parent reply other threads:[~2019-11-20 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 15:43 [dpdk-stable] [PATCH " Kevin Traynor
2019-11-13 15:43 ` [dpdk-stable] [PATCH 2/2] lib: fix Doxygen typos Kevin Traynor
2019-11-13 16:10 ` [dpdk-stable] [PATCH v2 1/2] lib: fix log typos Kevin Traynor
2019-11-13 16:10 ` [dpdk-stable] [PATCH v2 2/2] lib: fix Doxygen typos Kevin Traynor
2019-11-19 21:18 ` [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] lib: fix log typos David Marchand
2019-11-19 21:56 ` Kevin Traynor
2019-11-20 8:00 ` David Marchand
2019-11-20 13:29 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6e29e12-10ba-9fe0-b10f-d967bdee9ffa@redhat.com \
--to=ktraynor@redhat.com \
--cc=aconole@redhat.com \
--cc=alan.carew@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=liang.j.ma@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).