From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions
Date: Wed, 21 Sep 2016 17:16:37 +0100 [thread overview]
Message-ID: <e70eea08-c826-26ff-2391-f1942781f763@intel.com> (raw)
In-Reply-To: <3ee96eae-d94e-6046-0d29-8b7bcbe363ca@6wind.com>
On 9/21/2016 4:04 PM, Olivier Matz wrote:
> Hi Ferruh,
>
> Thanks for checking the API documentation.
> Please see few comments below.
>
> On 09/20/2016 06:17 PM, Ferruh Yigit wrote:
>> Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool")
>> Fixes: d1d914ebbc25 ("mempool: allocate in several memory chunks by default")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> lib/librte_mempool/rte_mempool.c | 4 +---
>> lib/librte_mempool/rte_mempool.h | 4 +---
>> 2 files changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
>> index df8b68c..e96d14f 100644
>> --- a/lib/librte_mempool/rte_mempool.c
>> +++ b/lib/librte_mempool/rte_mempool.c
>> @@ -908,9 +908,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
>> /*
>> * Create the mempool over already allocated chunk of memory.
>> * That external memory buffer can consists of physically disjoint pages.
>> - * Setting vaddr to NULL, makes mempool to fallback to original behaviour
>> - * and allocate space for mempool and it's elements as one big chunk of
>> - * physically continuos memory.
>> + * Setting vaddr to NULL, makes mempool to fallback to original behaviour.
>
> I would replace "original behaviour" by "rte_mempool_create() behaviour".
>
>> */
>> struct rte_mempool *
>> rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,
>> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
>> index 0243f9e..6fc331a 100644
>> --- a/lib/librte_mempool/rte_mempool.h
>> +++ b/lib/librte_mempool/rte_mempool.h
>> @@ -591,8 +591,6 @@ typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *);
>> *
>> * This function uses ``memzone_reserve()`` to allocate memory. The
>> * pool contains n elements of elt_size. Its size is set to n.
>> - * All elements of the mempool are allocated together with the mempool header,
>> - * in one physically continuous chunk of memory.
>
> While there, maybe we could replace ``memzone_reserve()`` by
> ``rte_memzone_reserve()``.
>
>> *
>> * @param name
>> * The name of the mempool.
>> @@ -748,7 +746,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,
>> *
>> * The mempool is allocated and initialized, but it is not populated: no
>> * memory is allocated for the mempool elements. The user has to call
>> - * rte_mempool_populate_*() or to add memory chunks to the pool. Once
>> + * rte_mempool_populate_*() to add memory chunks to the pool. Once
>> * populated, the user may also want to initialize each object with
>> * rte_mempool_obj_iter().
>> *
>>
Thanks for the comments, I will send a new version of the patch with
suggested fixes.
Thanks,
ferruh
next prev parent reply other threads:[~2016-09-21 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 16:17 Ferruh Yigit
2016-09-20 16:17 ` [dpdk-dev] [PATCH 2/2] mempool: fix comments for no contiguous flag Ferruh Yigit
2016-09-21 15:12 ` Olivier Matz
2016-09-21 16:15 ` Ferruh Yigit
2016-09-22 7:23 ` Olivier Matz
2016-09-21 15:04 ` [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions Olivier Matz
2016-09-21 16:16 ` Ferruh Yigit [this message]
2016-09-28 13:59 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2016-09-28 13:59 ` [dpdk-dev] [PATCH v2 2/2] mempool: fix comments for no contiguous flag Ferruh Yigit
2016-10-03 15:06 ` [dpdk-dev] [PATCH v2 1/2] mempool: fix comments for mempool create functions Olivier Matz
2016-10-04 9:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e70eea08-c826-26ff-2391-f1942781f763@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).