From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Jingjing Wu <jingjing.wu@intel.com>,
Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item
Date: Thu, 7 Dec 2017 15:52:44 -0800 [thread overview]
Message-ID: <e746964b-aadb-fe2b-3d0f-fa61776307a0@intel.com> (raw)
In-Reply-To: <20171204140320.GE4062@6wind.com>
On 12/4/2017 6:03 AM, Adrien Mazarguil wrote:
> On Fri, Dec 01, 2017 at 10:43:15AM +0000, Andrew Rybchenko wrote:
>> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
>>
>> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API.
>> Add default mask for the item.
>>
>> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Just one remaining nit, please see below. While you could address it through
> a subsequent patch, you might as well send v3 directly to make things easier
> for Ferruh.
>
> Otherwise it's all good, thanks.
May I take this as (for series):
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
>> ---
>> doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++
>> lib/librte_ether/rte_flow.c | 1 +
>> lib/librte_ether/rte_flow.h | 30 ++++++++++++++++++++++++++++++
>> 3 files changed, 43 insertions(+)
>>
>> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
>> index d158be5..5b8f9c5 100644
>> --- a/doc/guides/prog_guide/rte_flow.rst
>> +++ b/doc/guides/prog_guide/rte_flow.rst
>> @@ -980,6 +980,18 @@ Matches an ESP header.
>> - ``hdr``: ESP header definition (``rte_esp.h``).
>> - Default ``mask`` matches SPI only.
>>
>> +Item: ``GENEVE``
>> +^^^^^^^^^^^^^^^
>
> Missing "^" under title, this may trigger a warning during documentation
> generation.
I can add that one missing '^' while applying, no patch required.
next prev parent reply other threads:[~2017-12-07 23:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 8:21 [dpdk-dev] [PATCH 0/2] ethdev: add GENEVE to flow API Andrew Rybchenko
2017-11-20 8:22 ` [dpdk-dev] [PATCH 1/2] ethdev: add GENEVE flow pattern item Andrew Rybchenko
2017-11-23 9:39 ` Adrien Mazarguil
2017-11-20 8:22 ` [dpdk-dev] [PATCH 2/2] app/testpmd: support GENEVE pattern item in flow rules Andrew Rybchenko
2017-11-23 9:40 ` Adrien Mazarguil
2017-11-23 9:39 ` [dpdk-dev] [PATCH 0/2] ethdev: add GENEVE to flow API Adrien Mazarguil
2017-11-23 10:07 ` Andrew Rybchenko
2017-12-01 10:43 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2017-12-01 10:43 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item Andrew Rybchenko
2017-12-04 14:03 ` Adrien Mazarguil
2017-12-07 23:52 ` Ferruh Yigit [this message]
2017-12-08 10:52 ` Adrien Mazarguil
2017-12-08 19:06 ` Ferruh Yigit
2017-12-01 10:43 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: support GENEVE pattern item in flow rules Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e746964b-aadb-fe2b-3d0f-fa61776307a0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Roman.Zhukov@oktetlabs.ru \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).