From: Olivier Matz <olivier.matz@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, thomas.monjalon@6wind.com
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for mbuf structure
Date: Tue, 19 Jul 2016 17:04:01 +0200 [thread overview]
Message-ID: <e765c1a4-4f98-b26f-c4c9-d693951b2569@6wind.com> (raw)
In-Reply-To: <20160719144018.GA10912@bricha3-MOBL3>
Hi Bruce,
On 07/19/2016 04:40 PM, Bruce Richardson wrote:
> On Tue, Jul 19, 2016 at 04:01:15PM +0200, Olivier Matz wrote:
>> For 16.11, the mbuf structure will be modified implying ABI breakage.
>> Some discussions already took place here:
>> http://www.dpdk.org/dev/patchwork/patch/12878/
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index f502f86..2245bc2 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -41,3 +41,9 @@ Deprecation Notices
>> * The mempool functions for single/multi producer/consumer are deprecated and
>> will be removed in 16.11.
>> It is replaced by rte_mempool_generic_get/put functions.
>> +
>> +* ABI changes are planned for 16.11 in the ``rte_mbuf`` structure: some
>> + fields will be reordered to facilitate the writing of ``data_off``,
>> + ``refcnt``, and ``nb_segs`` in one operation. Indeed, some platforms
>> + have an overhead if the store address is not naturally aligned. The
>> + useless ``port`` field will also be removed at the same occasion.
>> --
>
> Have we fully bottomed out on the mbuf changes. I'm not sure that once patches
> start getting considered for merge, new opinions may come forward. For instance,
> is the "port" field really "useless"?
>
> Would it not be better to put in a less specific deprecation notice? What happens
> if this notice goes in and the final changes are different from those called out
> here?
Yes, you are right. What about the following text?
ABI changes are planned for 16.11 in the ``rte_mbuf`` structure: some
fields may be reordered to facilitate the writing of ``data_off``,
``refcnt``, and ``nb_segs`` in one operation. Indeed, some platforms
have an overhead if the store address is not naturally aligned. The
``port`` field may also be removed at the same occasion.
Thanks,
Olivier
next prev parent reply other threads:[~2016-07-19 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 14:01 Olivier Matz
2016-07-19 14:40 ` Bruce Richardson
2016-07-19 15:04 ` Olivier Matz [this message]
2016-07-19 15:07 ` Richardson, Bruce
2016-07-19 15:28 ` Olivier Matz
2016-07-20 7:16 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2016-07-20 8:54 ` Ferruh Yigit
2016-07-27 8:33 ` Thomas Monjalon
2016-07-28 18:04 ` Thomas Monjalon
2016-07-27 9:34 ` Ananyev, Konstantin
2016-07-28 2:35 ` John Daley (johndale)
2016-07-28 2:39 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e765c1a4-4f98-b26f-c4c9-d693951b2569@6wind.com \
--to=olivier.matz@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).