From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: fix return value on enqueue path
Date: Wed, 12 Sep 2018 08:57:55 +0200 [thread overview]
Message-ID: <e76f35ee-ce2f-6e6b-4a87-b81a82fdd390@redhat.com> (raw)
In-Reply-To: <20180906045927.12619-1-tiwei.bie@intel.com>
On 09/06/2018 06:59 AM, Tiwei Bie wrote:
> Fixes: 62250c1d0978 ("vhost: extract split ring handling from Rx and Tx functions")
> Fixes: a922401f35cc ("vhost: add Rx support for packed ring")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> lib/librte_vhost/virtio_net.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Good catch! Thanks for the fix.
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> index 99c7afc88..4bfae76a6 100644
> --- a/lib/librte_vhost/virtio_net.c
> +++ b/lib/librte_vhost/virtio_net.c
> @@ -888,6 +888,7 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
> struct rte_mbuf **pkts, uint32_t count)
> {
> struct vhost_virtqueue *vq;
> + uint32_t nb_tx = 0;
>
> VHOST_LOG_DEBUG(VHOST_DATA, "(%d) %s\n", dev->vid, __func__);
> if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->nr_vring))) {
> @@ -915,9 +916,9 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
> goto out;
>
> if (vq_is_packed(dev))
> - count = virtio_dev_rx_packed(dev, vq, pkts, count);
> + nb_tx = virtio_dev_rx_packed(dev, vq, pkts, count);
> else
> - count = virtio_dev_rx_split(dev, vq, pkts, count);
> + nb_tx = virtio_dev_rx_split(dev, vq, pkts, count);
>
> out:
> if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))
> @@ -926,7 +927,7 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
> out_access_unlock:
> rte_spinlock_unlock(&vq->access_lock);
>
> - return count;
> + return nb_tx;
> }
>
> uint16_t
>
next prev parent reply other threads:[~2018-09-12 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 4:59 Tiwei Bie
2018-09-12 6:57 ` Maxime Coquelin [this message]
2018-09-12 7:02 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e76f35ee-ce2f-6e6b-4a87-b81a82fdd390@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).