From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xueming Li <xuemingl@mellanox.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
FerruhYigitferruh.yigit@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix ICC compiler warning
Date: Fri, 20 Oct 2017 18:05:12 -0700 [thread overview]
Message-ID: <e78ae807-2773-5608-c63f-5071ab82163b@intel.com> (raw)
In-Reply-To: <20171017024643.1011-1-xuemingl@mellanox.com>
On 10/16/2017 7:46 PM, Xueming Li wrote:
> Initialize variable to avoid ICC compiler warning:
> http://www.dpdk.org/ml/archives/dev/2017-October/077971.html
Hi Xueming, Nelio,
I disabled that warning for ICC in Makefile [1], as mentioned in above mail.
If you prefer to fix it instead of disable, can you please update the patch,
and remove that workaround in this patch?
Thanks,
ferruh
[1]
http://dpdk.org/browse/dpdk/tree/drivers/net/mlx5/Makefile#n93
# Disable false positive warning
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
CFLAGS_mlx5_txq.o += -wd3656
endif
>
> Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file...")
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_txq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index 9deaa7e..93f1388 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -246,6 +246,7 @@
> int already_mapped;
> size_t page_size = sysconf(_SC_PAGESIZE);
>
> + memset(pages, 0, priv->txqs_n * sizeof(uintptr_t));
> /*
> * As rdma-core, UARs are mapped in size of OS page size.
> * Use aligned address to avoid duplicate mmap.
>
prev parent reply other threads:[~2017-10-21 1:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 2:46 Xueming Li
2017-10-17 7:56 ` Nélio Laranjeiro
2017-10-23 21:54 ` Ferruh Yigit
2017-10-24 12:28 ` Xueming(Steven) Li
2017-10-21 1:05 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e78ae807-2773-5608-c63f-5071ab82163b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=FerruhYigitferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).