From: Jiri Slaby <jslaby@suse.cz>
To: Kevin Traynor <ktraynor@redhat.com>,
David Marchand <david.marchand@redhat.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
dev@dpdk.org, Luca Boccassi <bluca@debian.org>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH stable-22.11] kni: fix build with Linux 6.8
Date: Tue, 12 Mar 2024 11:40:09 +0100 [thread overview]
Message-ID: <e8008dc4-6e43-4c6c-8b8b-a2214194fcb2@suse.cz> (raw)
In-Reply-To: <c47723d8-5e1c-439e-ac14-0b9681b1bec6@redhat.com>
On 12. 03. 24, 11:26, Kevin Traynor wrote:
> On 12/03/2024 08:59, David Marchand wrote:
>> Hello Jiri,
>>
>> On Tue, Mar 12, 2024 at 9:57 AM Jiri Slaby <jslaby@suse.cz> wrote:
>>>
>>> strlcpy() was removed in commit d26270061ae6 (string: Remove strlcpy()), use
>>> strscpy() instead.
>>>
>>> The patches fixes this:
>>> kernel/linux/kni/kni_net.c: In function ‘kni_get_drvinfo’:
>>> kernel/linux/kni/kni_net.c:835:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’?
>>>
>>> Intended esp. for stable/22.11. It should go wherever kni is still in
>>> the tree.
>>
>> Thanks for the patch.
>>
>> Cc: stable and LTS maintainers.
>>
>>>
>>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>>
>>
>
> Thanks Jiri and David. I will take this for 21.11 LTS also.
Just heads up: I've just realized, that strscpy() was introduces only in
commit 30035e45753b708e7d47a98398500ca005e02b86
Author: Chris Metcalf <cmetcalf@ezchip.com>
Date: Wed Apr 29 12:52:04 2015 -0400
string: provide strscpy()
in v4.3. If you support older kernels, the patch needs modifications.
Like some #if's depending on the kernel version or some HAVE_STRSCPY
defines.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2024-03-12 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240312084914.92056-1-jslaby@suse.cz>
2024-03-12 8:59 ` David Marchand
2024-03-12 10:26 ` Kevin Traynor
2024-03-12 10:40 ` Jiri Slaby [this message]
2024-03-12 11:20 ` Kevin Traynor
2024-04-18 10:25 ` Kevin Traynor
2024-04-18 10:32 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8008dc4-6e43-4c6c-8b8b-a2214194fcb2@suse.cz \
--to=jslaby@suse.cz \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).