From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Radu Nicolau <radu.nicolau@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, declan.doherty@intel.com
Subject: Re: [dpdk-dev] [PATCH] test/bonding: assign non-zero MAC to null devices
Date: Wed, 31 Jan 2018 19:31:46 +0000 [thread overview]
Message-ID: <e8375ff6-2348-fca6-a358-45d546c1ed3c@intel.com> (raw)
In-Reply-To: <1517235962-25128-1-git-send-email-radu.nicolau@intel.com>
On 1/29/2018 2:26 PM, Radu Nicolau wrote:
Hi Radu,
Can you please describe why this is needed?
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> test/test/test_link_bonding_rssconf.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c
> index cf9c4b0..518c4c1 100644
> --- a/test/test/test_link_bonding_rssconf.c
> +++ b/test/test/test_link_bonding_rssconf.c
> @@ -505,6 +505,7 @@ test_setup(void)
> int port_id;
> char name[256];
> struct slave_conf *port;
> + struct ether_addr mac_addr = {0};
>
> if (test_params.mbuf_pool == NULL) {
>
> @@ -536,6 +537,10 @@ test_setup(void)
> TEST_ASSERT_SUCCESS(retval, "Failed to configure virtual ethdev %s\n",
> name);
>
> + /* assign a non-zero MAC */
> + mac_addr.addr_bytes[5] = 0x10 + port->port_id;
> + rte_eth_dev_default_mac_addr_set(port->port_id, &mac_addr);
> +
> rte_eth_dev_info_get(port->port_id, &port->dev_info);
> }
>
>
next prev parent reply other threads:[~2018-01-31 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 14:26 Radu Nicolau
2018-01-31 19:31 ` Ferruh Yigit [this message]
2018-02-01 10:50 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2018-02-01 11:06 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
2018-02-05 15:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8375ff6-2348-fca6-a358-45d546c1ed3c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).