From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework/config: fix issue with string values
Date: Thu, 1 Jul 2021 08:49:30 +0000 [thread overview]
Message-ID: <e943b22a53f54963a01d0e8ed615b4e3@intel.com> (raw)
In-Reply-To: <20210625130753.18155-1-ohilyard@iol.unh.edu>
> -----Original Message-----
> From: ohilyard@iol.unh.edu <ohilyard@iol.unh.edu>
> Sent: 2021年6月25日 21:08
> To: Tu, Lijuan <lijuan.tu@intel.com>
> Cc: dts@dpdk.org; Owen Hilyard <ohilyard@iol.unh.edu>
> Subject: [PATCH] framework/config: fix issue with string values
>
> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> String values were ran through 'eval' like everything else as part of parsing
> config files. This will work the first time if there are quotes around the value, but
> if the --update-expected flag is passed, it will re-write the config file without
> quotes around the string value. This then cause an error when the value is
> 'eval'ed again, since it will now be evaluated as a variable.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
Applied, thanks
prev parent reply other threads:[~2021-07-01 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 13:07 ohilyard
2021-07-01 8:49 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e943b22a53f54963a01d0e8ed615b4e3@intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).