From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Srinivasan J <srinidpdk@gmail.com>, "Dai, Wei" <wei.dai@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+
Date: Thu, 29 Jun 2017 14:00:29 +0100 [thread overview]
Message-ID: <e94cc676-2be5-0c4f-6cec-481eeaad498f@intel.com> (raw)
In-Reply-To: <CAEbeQ+qhnVV-_GinNbQ=fuTy8MSwwv9rK+sESypLbLf1nSEPgg@mail.gmail.com>
On 5/19/2017 11:04 AM, Srinivasan J wrote:
> Hi Wei,
> Yes the changes are in ixgbe_dev_start( ), the patch shows
> the function as eth_ixgbevf_pci_remove() probably due to the way diff
> recognizes the change. I have tested the change using Intel
> Corporation 82599ES.
Hi Srinivasan, Wei,
What is the latest status of the patch? Are all issues pointed by Wie
addressed in the patch, or are we waiting for a new version?
Thanks,
ferruh
>
> Thanks,
> Srini
>
> On Tue, May 16, 2017 at 9:04 AM, Dai, Wei <wei.dai@intel.com> wrote:
>> Hi, Srini
>>
>> There is a bit confusion. Your patch shows that your code is added into the function eth_ixgbevf_pci_remove( ).
>> But it is not. It is added into the fucntion ixgbe_dev_start( ), right ?
>> So would you please rebase it to R 17.05 ?
>>
>> Which type of ixgbe device id did you tested ?
>>
>> There are many MAC types with different device id.
>>
>> The function ixgbe_pf_reset_hw(hw) is called before your adding code.
>> ixgbe_pf_reset_hw() calls hw->mac.ops.reset_hw( ) which may points to following different function for different MAC type.
>> Ixgbe_reset_hw_82598( ) calls hw->phy.ops.init(hw) if hw->phy.reset_disable == false .
>> Ixgbe_reset_hw_82599( ) calls hw->phy.ops.init(hw) unconditionally.
>> ixgbe_reset_hw_X540( ) doesn't' call pw->phy.ops.init(hw). For X540, hw->phy.ops.init points to ixgbe_init_phy_ops_generic() which only initialize some function pointers.
>> Ixgbe_rest_hw_x550em() calls hw->phy.ops.init(hw) unconditionally.
>>
>> And for VF, ixgbe_reset_hw_vf( ) and ixgbevf_hv_reset_hw_vf( ) don't call hw->phy.ops.init(hw) anywhere.
>>
>> Thanks & Best Regards
>> -Wei
>>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
>>> Sent: Sunday, May 7, 2017 6:36 AM
>>> To: Srinivasan J <srinidpdk@gmail.com>
>>> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev,
>>> Konstantin <konstantin.ananyev@intel.com>
>>> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped
>>> SFP/SFP+
>>>
>>> 06/05/2017 15:51, Srinivasan J:
>>>> Hi,
>>>> Do we need an explicit "Acked-by" keyword for this
>>>> patch to be accepted and applied?
>>>
>>> Yes, given it is not a trivial patch, an ack from the maintainer is required.
>>> Anyway, it has been submitted too late for 17.05 testing.
next prev parent reply other threads:[~2017-06-29 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 10:47 Srini J
2017-04-21 4:52 ` Lu, Wenzhuo
2017-04-24 6:23 ` Srinivasan J
2017-04-24 7:15 ` Lu, Wenzhuo
2017-04-24 10:51 ` Srinivasan J
2017-04-25 1:23 ` Lu, Wenzhuo
2017-05-06 13:51 ` Srinivasan J
2017-05-06 22:36 ` Thomas Monjalon
2017-05-16 3:34 ` Dai, Wei
2017-05-19 10:04 ` Srinivasan J
2017-06-29 13:00 ` Ferruh Yigit [this message]
2017-07-18 14:56 ` Dai, Wei
2017-08-28 9:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e94cc676-2be5-0c4f-6cec-481eeaad498f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=srinidpdk@gmail.com \
--cc=thomas@monjalon.net \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).