From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Nipun Gupta <nipun.gupta@nxp.com>, <dev@dpdk.org>
Cc: <jerin.jacob@caviumnetworks.com>, <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] drivers: add queue parameter in event processing callback
Date: Fri, 13 Oct 2017 20:18:15 +0530 [thread overview]
Message-ID: <ea17b231-bd38-08a6-37ad-30059e1e3c3f@nxp.com> (raw)
In-Reply-To: <1507828729-18194-1-git-send-email-nipun.gupta@nxp.com>
On 10/12/2017 10:48 PM, Nipun Gupta wrote:
> For event dequeues for ethernet queues, a dpaa2_queue structure is
> required to get the configuration for that ethernet queue. Based on
> this configuration the rte_event is to be filled at the ingress side.
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
> drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 4 ++++
> drivers/event/dpaa2/dpaa2_eventdev.c | 8 +++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
> index 8f39cfb..e14a9a9 100644
> --- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
> +++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
> @@ -125,9 +125,12 @@ struct queue_storage_info_t {
> int toggle;
> };
>
> +struct dpaa2_queue;
> +
> typedef void (dpaa2_queue_cb_dqrr_t)(struct qbman_swp *swp,
> const struct qbman_fd *fd,
> const struct qbman_result *dq,
> + struct dpaa2_queue *rxq,
> struct rte_event *ev);
>
> struct dpaa2_queue {
> @@ -144,6 +147,7 @@ struct dpaa2_queue {
> struct queue_storage_info_t *q_storage;
> struct qbman_result *cscn;
> };
> + struct rte_event ev;
> dpaa2_queue_cb_dqrr_t *cb;
> };
>
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> index 81286a8..8a6a3e3 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -189,10 +189,14 @@ static void dpaa2_eventdev_dequeue_wait(uint64_t timeout_ticks)
> static void dpaa2_eventdev_process_parallel(struct qbman_swp *swp,
> const struct qbman_fd *fd,
> const struct qbman_result *dq,
> + struct dpaa2_queue *rxq,
> struct rte_event *ev)
> {
> struct rte_event *ev_temp =
> (struct rte_event *)DPAA2_GET_FD_ADDR(fd);
> +
> + RTE_SET_USED(rxq);
> +
> rte_memcpy(ev, ev_temp, sizeof(struct rte_event));
> rte_free(ev_temp);
>
> @@ -202,6 +206,7 @@ static void dpaa2_eventdev_process_parallel(struct qbman_swp *swp,
> static void dpaa2_eventdev_process_atomic(struct qbman_swp *swp,
> const struct qbman_fd *fd,
> const struct qbman_result *dq,
> + struct dpaa2_queue *rxq,
> struct rte_event *ev)
> {
> struct rte_event *ev_temp =
> @@ -209,6 +214,7 @@ static void dpaa2_eventdev_process_atomic(struct qbman_swp *swp,
> uint8_t dqrr_index = qbman_get_dqrr_idx(dq);
>
> RTE_SET_USED(swp);
> + RTE_SET_USED(rxq);
>
> rte_memcpy(ev, ev_temp, sizeof(struct rte_event));
> rte_free(ev_temp);
> @@ -265,7 +271,7 @@ static void dpaa2_eventdev_process_atomic(struct qbman_swp *swp,
>
> rxq = (struct dpaa2_queue *)qbman_result_DQ_fqd_ctx(dq);
> if (rxq) {
> - rxq->cb(swp, fd, dq, &ev[num_pkts]);
> + rxq->cb(swp, fd, dq, rxq, &ev[num_pkts]);
> } else {
> qbman_swp_dqrr_consume(swp, dq);
> PMD_DRV_LOG(ERR, "Null Return VQ received\n");
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
next prev parent reply other threads:[~2017-10-13 14:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 17:51 [dpdk-dev] [PATCH " Nipun Gupta
2017-10-10 17:51 ` [dpdk-dev] [PATCH 2/4] net/dpaa2: add API's to support event eth adapter Nipun Gupta
2017-10-10 17:51 ` [dpdk-dev] [PATCH 3/4] event/dpaa2: " Nipun Gupta
2017-10-11 3:45 ` Rao, Nikhil
2017-10-11 11:03 ` Nipun Gupta
2017-10-11 4:10 ` Rao, Nikhil
2017-10-11 11:03 ` Nipun Gupta
2017-10-10 17:51 ` [dpdk-dev] [PATCH 4/4] event/dpaa2: improve the err handling and log msg Nipun Gupta
2017-10-12 17:18 ` [dpdk-dev] [PATCH v2 1/4] drivers: add queue parameter in event processing callback Nipun Gupta
2017-10-12 17:18 ` [dpdk-dev] [PATCH v2 2/4] net/dpaa2: add API's to support event eth adapter Nipun Gupta
2017-10-13 14:55 ` Hemant Agrawal
2017-10-12 17:18 ` [dpdk-dev] [PATCH v2 3/4] event/dpaa2: " Nipun Gupta
2017-10-13 5:57 ` Rao, Nikhil
2017-10-13 14:52 ` Hemant Agrawal
2017-10-12 17:18 ` [dpdk-dev] [PATCH v2 4/4] event/dpaa2: improve the err handling and log msg Nipun Gupta
2017-10-13 14:52 ` Hemant Agrawal
2017-10-13 14:48 ` Hemant Agrawal [this message]
2017-10-16 21:44 ` [dpdk-dev] [PATCH v3 1/4] drivers: add queue parameter in event processing callback Nipun Gupta
2017-10-16 21:44 ` [dpdk-dev] [PATCH v3 2/4] net/dpaa2: add API's to support event eth adapter Nipun Gupta
2017-10-16 21:44 ` [dpdk-dev] [PATCH v3 3/4] event/dpaa2: " Nipun Gupta
2017-10-17 5:00 ` Jerin Jacob
2017-10-17 10:28 ` Nipun Gupta
2017-10-16 21:44 ` [dpdk-dev] [PATCH v3 4/4] event/dpaa2: improve the err handling and log msg Nipun Gupta
2017-10-17 16:38 ` [dpdk-dev] [PATCH v4 1/5] drivers: add queue parameter in event processing callback Nipun Gupta
2017-10-17 16:38 ` [dpdk-dev] [PATCH v4 2/5] net/dpaa2: add API's to support event eth adapter Nipun Gupta
2017-10-17 12:32 ` Hemant Agrawal
2017-10-17 16:38 ` [dpdk-dev] [PATCH v4 3/5] drivers: add net as dependency for event drivers Nipun Gupta
2017-10-21 10:05 ` Jerin Jacob
2017-10-17 16:38 ` [dpdk-dev] [PATCH v4 4/5] event/dpaa2: support event eth adapter Nipun Gupta
2017-10-17 16:38 ` [dpdk-dev] [PATCH v4 5/5] event/dpaa2: improve the err handling and log msg Nipun Gupta
2017-10-23 12:37 ` [dpdk-dev] [PATCH v5 1/5] drivers: add queue parameter in event processing callback Nipun Gupta
2017-10-23 12:37 ` [dpdk-dev] [PATCH v5 2/5] net/dpaa2: add API's to support event eth adapter Nipun Gupta
2017-10-23 12:37 ` [dpdk-dev] [PATCH v5 3/5] drivers: add net as dependency for event drivers Nipun Gupta
2017-10-23 6:24 ` Jerin Jacob
2017-10-23 12:37 ` [dpdk-dev] [PATCH v5 4/5] event/dpaa2: support event eth adapter Nipun Gupta
2017-10-23 12:37 ` [dpdk-dev] [PATCH v5 5/5] event/dpaa2: improve the err handling and log msg Nipun Gupta
2017-10-23 17:49 ` [dpdk-dev] [PATCH v5 1/5] drivers: add queue parameter in event processing callback Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea17b231-bd38-08a6-37ad-30059e1e3c3f@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nikhil.rao@intel.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).