From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: fix use after free
Date: Tue, 18 Apr 2017 10:20:41 +0200 [thread overview]
Message-ID: <ea66583d-db34-255c-183a-c61f77fe7a63@redhat.com> (raw)
In-Reply-To: <1492414024-18413-1-git-send-email-yuanhan.liu@linux.intel.com>
On 04/17/2017 09:27 AM, Yuanhan Liu wrote:
> A "return" is missing on error, which could lead to a "use after free"
> issue (about var "conn").
>
> Fixes: 65388b43f592 ("vhost: fix fd leaks for vhost-user server mode")
> Coverity issue: 143476
>
> Reported-by: John McNamara <john.mcnamara@intel.com>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
> lib/librte_vhost/socket.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks!
Maxime
next prev parent reply other threads:[~2017-04-18 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 7:27 Yuanhan Liu
2017-04-18 8:20 ` Maxime Coquelin [this message]
2017-04-19 1:05 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea66583d-db34-255c-183a-c61f77fe7a63@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).