From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Wang, Yinan" <yinan.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"matan@mellanox.com" <matan@mellanox.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Liu, Yong" <yong.liu@intel.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 0/2] Fix vhost performance regression
Date: Fri, 24 Jul 2020 10:54:54 +0200 [thread overview]
Message-ID: <ea83bb41-a08d-5157-4f43-ac1db0026f2a@redhat.com> (raw)
In-Reply-To: <5a8329d8-4835-de6b-bce3-498b587c3cc9@redhat.com>
On 7/24/20 9:06 AM, Maxime Coquelin wrote:
> Hi Yinan,
>
> On 7/24/20 6:55 AM, Wang, Yinan wrote:
>> Hi Maxime,
>>
>> The performance drop issue can be fixed, thanks!
>> The multi-queues interrupt issue still exist w/ this patch set.
>
> Thanks for the test report, so that's only half good.
> I'm setting up the multi-queues interrupt test case to further debug it.
I have now a reproducer, i.e. only interrupts are received on rxq0.
(gdb) p *((struct internal_list *)internal_list)->eth_dev->intr_handle
$20 = {
{
vfio_dev_fd = 0,
uio_cfg_fd = 0
},
fd = 0,
type = RTE_INTR_HANDLE_VDEV,
max_intr = 2,
nb_efd = 1,
efd_counter_size = 8 '\b',
efds = {622, 621, 624, 626, 628, 630, 632, 634, 636, 638, 640, 642,
692, 646, 701, 650, 0 <repeats 496 times>},
elist = {{
status = 1,
fd = 622,
epfd = 645,
epdata = {
event = 2147483651,
data = 0x1,
cb_fun = 0x8af840 <eal_intr_proc_rxtx_intr>,
cb_arg = 0x7f4df0001580
}
}, {
status = 0,
fd = 0,
epfd = 0,
epdata = {
event = 0,
data = 0x0,
cb_fun = 0x0,
cb_arg = 0x0
}
} <repeats 511 times>},
intr_vec = 0x7f4df0007db0
}
In above dump, we can see the efds are well set via the fix provided by
Matan, but max_intr and nb_efd aren't so polling won't take them into
account.
I'm working on a fix.
Regards,
Maxime
> Regards,
> Maxime
>
>> BR,
>> Yinan
>>
>>> -----Original Message-----
>>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>>> Sent: 2020?7?23? 21:09
>>> To: dev@dpdk.org; matan@mellanox.com; Xia, Chenbo
>>> <chenbo.xia@intel.com>; Liu, Yong <yong.liu@intel.com>; Wang, Yinan
>>> <yinan.wang@intel.com>
>>> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
>>> david.marchand@redhat.com; Maxime Coquelin
>>> <maxime.coquelin@redhat.com>
>>> Subject: [PATCH 0/2] Fix vhost performance regression
>>>
>>> Hi,
>>>
>>> This series aims at fixing the performance degradation reported
>>> by Intel QE. I managed to reproduce the issue, and this series
>>> fixes it.
>>>
>>> I only tested the first test case provided in the Bz[0], but wanted
>>> to send early for Intel QE to try and confirm it solves the issue.
>>>
>>> I will work on reproducing the other test cases, and see if this
>>> also fixes them.
>>>
>>> Thanks to Intel QE team for finding this issue.
>>> Maxime
>>>
>>> [0]: https://bugs.dpdk.org/show_bug.cgi?id=507#c0
>>>
>>> Maxime Coquelin (2):
>>> vhost: fix guest notification setting
>>> net/vhost: fix queue update
>>>
>>> drivers/net/vhost/rte_eth_vhost.c | 25 ++++++-------------------
>>> lib/librte_vhost/vhost.c | 24 ++++++++++++++++++++----
>>> lib/librte_vhost/vhost.h | 5 +++++
>>> lib/librte_vhost/vhost_user.c | 11 ++++++++---
>>> 4 files changed, 39 insertions(+), 26 deletions(-)
>>>
>>> --
>>> 2.26.2
>>
>
next prev parent reply other threads:[~2020-07-24 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 13:08 Maxime Coquelin
2020-07-23 13:08 ` [dpdk-dev] [PATCH 1/2] vhost: fix guest notification setting Maxime Coquelin
2020-07-27 13:46 ` Xia, Chenbo
2020-07-23 13:08 ` [dpdk-dev] [PATCH 2/2] net/vhost: fix queue update Maxime Coquelin
2020-07-27 13:54 ` Xia, Chenbo
2020-07-24 4:55 ` [dpdk-dev] [PATCH 0/2] Fix vhost performance regression Wang, Yinan
2020-07-24 7:06 ` Maxime Coquelin
2020-07-24 8:54 ` Maxime Coquelin [this message]
2020-07-24 15:43 ` Maxime Coquelin
2020-07-27 8:28 ` Matan Azrad
2020-07-24 12:42 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea83bb41-a08d-5157-4f43-ac1db0026f2a@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yinan.wang@intel.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).