From: Akhil Goyal <akhil.goyal@nxp.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5 03/10] examples/ipsec-secgw: fix crypto-op might never get dequeued
Date: Wed, 2 Jan 2019 11:44:17 +0000 [thread overview]
Message-ID: <eafd3929-c419-cc88-4b80-54edfbb4f12f@nxp.com> (raw)
In-Reply-To: <1546011238-22318-4-git-send-email-konstantin.ananyev@intel.com>
On 12/28/2018 9:03 PM, Konstantin Ananyev wrote:
> In some cases crypto-ops could never be dequeued from the crypto-device.
> The easiest way to reproduce:
> start ipsec-secgw with crypto-dev and send to it less then 32 packets.
> none packets will be forwarded.
> Reason for that is that the application does dequeue() from crypto-queues
> only when new packets arrive.
> This patch makes sure it calls dequeue() on a regular basis.
>
> Fixes: c64278c0c18b ("examples/ipsec-secgw: rework processing loop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> examples/ipsec-secgw/ipsec-secgw.c | 136 ++++++++++++++++++++++++-----
> examples/ipsec-secgw/ipsec.c | 60 ++++++++-----
> examples/ipsec-secgw/ipsec.h | 11 +++
> 3 files changed, 165 insertions(+), 42 deletions(-)
[snip]
> +
> /* main processing loop */
> static int32_t
> main_loop(__attribute__((unused)) void *dummy)
> @@ -866,7 +958,8 @@ main_loop(__attribute__((unused)) void *dummy)
> diff_tsc = cur_tsc - prev_tsc;
>
> if (unlikely(diff_tsc > drain_tsc)) {
> - drain_buffers(qconf);
> + drain_tx_buffers(qconf);
> + drain_crypto_buffers(qconf);
> prev_tsc = cur_tsc;
> }
>
> @@ -880,6 +973,9 @@ main_loop(__attribute__((unused)) void *dummy)
> if (nb_rx > 0)
> process_pkts(qconf, pkts, nb_rx, portid);
> }
> +
> + drain_inbound_crypto_queues(qconf, &qconf->inbound);
> + drain_outbound_crypto_queues(qconf, &qconf->outbound);
drain_inbound_crypto_queues and drain_outbound_crypto_queues should be called based on diff_tsc.
moving these two lines above after drain_crypto_buffers will improve the performance drop caused due to this patch.
next prev parent reply other threads:[~2019-01-02 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1544805623-18150-2-git-send-email-konstantin.ananyev@intel.com>
2018-12-28 15:33 ` [dpdk-stable] " Konstantin Ananyev
2019-01-02 11:44 ` Akhil Goyal [this message]
2019-01-02 13:43 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2019-01-02 13:50 ` Akhil Goyal
2019-01-02 15:06 ` Ananyev, Konstantin
2018-12-28 15:33 ` [dpdk-stable] [PATCH v5 04/10] examples/ipsec-secgw: fix outbound codepath for single SA Konstantin Ananyev
2018-12-28 15:33 ` [dpdk-stable] [PATCH v5 05/10] examples/ipsec-secgw: make local variables static Konstantin Ananyev
2018-12-28 15:33 ` [dpdk-stable] [PATCH v5 06/10] examples/ipsec-secgw: fix inbound SA checking Konstantin Ananyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eafd3929-c419-cc88-4b80-54edfbb4f12f@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).