From: santosh <santosh.shukla@caviumnetworks.com>
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: konstantin.ananyev@intel.com, jingjing.wu@intel.com,
Nemanja Marjanovic <nemanja.marjanovic@intel.com>,
Rory Sexton <rory.sexton@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/9] lib/librte_power: add extra msg type for policies
Date: Wed, 4 Oct 2017 21:06:27 +0530 [thread overview]
Message-ID: <eb73493c-52c1-1637-8088-d7bc96f1432b@caviumnetworks.com> (raw)
In-Reply-To: <1507108515-186477-3-git-send-email-david.hunt@intel.com>
Hi David,
On Wednesday 04 October 2017 02:45 PM, David Hunt wrote:
> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
my 2cent:
General comment on implementation approach:
IMO, we should avoid PMD details in common lib area.
example: file channel_commons.h has ifdef clutter referencing
i40e pmds all over.
Perhaps we should introduce opaque handle example void * or introduce pmd
specific callback/handle which points to PMD specific metadata in power library.
Example:
struct channel_packet {
void *pmd_specific_metadata;
}
Or someway via callback (I'm not sure at the moment)
so that we could hide PMD details in common area.
Thanks.
> lib/librte_power/channel_commands.h | 52 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h
> index 484085b..1599706 100644
> --- a/lib/librte_power/channel_commands.h
> +++ b/lib/librte_power/channel_commands.h
> @@ -46,6 +46,7 @@ extern "C" {
> /* Valid Commands */
> #define CPU_POWER 1
> #define CPU_POWER_CONNECT 2
> +#define PKT_POLICY 3
>
> /* CPU Power Command Scaling */
> #define CPU_POWER_SCALE_UP 1
> @@ -54,11 +55,62 @@ extern "C" {
> #define CPU_POWER_SCALE_MIN 4
> #define CPU_POWER_ENABLE_TURBO 5
> #define CPU_POWER_DISABLE_TURBO 6
> +#define HOURS 24
> +
> +#ifdef RTE_LIBRTE_I40E_PMD
> +#define MAX_VFS 10
> +#endif
> +
> +#define MAX_VCPU_PER_VM 8
> +
> +typedef enum {false, true} bool;
> +
> +struct t_boost_status {
> + bool tbEnabled;
> +};
> +
> +struct timer_profile {
> + int busy_hours[HOURS];
> + int quiet_hours[HOURS];
> +#ifdef RTE_LIBRTE_I40E_PMD
> + int hours_to_use_traffic_profile[HOURS];
> +#endif
> +};
> +
> +enum workload {HIGH, MEDIUM, LOW};
> +enum policy_to_use {
> +#ifdef RTE_LIBRTE_I40E_PMD
> + TRAFFIC,
> +#endif
> + TIME,
> + WORKLOAD
> +};
> +
> +#ifdef RTE_LIBRTE_I40E_PMD
> +struct traffic {
> + uint32_t min_packet_thresh;
> + uint32_t avg_max_packet_thresh;
> + uint32_t max_max_packet_thresh;
> +};
> +#endif
>
> struct channel_packet {
> uint64_t resource_id; /**< core_num, device */
> uint32_t unit; /**< scale down/up/min/max */
> uint32_t command; /**< Power, IO, etc */
> + char vm_name[32];
> +
> +#ifdef RTE_LIBRTE_I40E_PMD
> + uint64_t vfid[MAX_VFS];
> + int nb_mac_to_monitor;
> + struct traffic traffic_policy;
> +#endif
> + uint8_t vcpu_to_control[MAX_VCPU_PER_VM];
> + uint8_t num_vcpu;
> + struct timer_profile timer_policy;
> + enum workload workload;
> + enum policy_to_use policy_to_use;
> + struct t_boost_status t_boost_status;
> };
>
>
next prev parent reply other threads:[~2017-10-04 15:36 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 16:02 [dpdk-dev] [PATCH v1 0/10] Policy Based Power Control for Guest David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 01/10] net/i40e: add API to convert VF Id to PF Id David Hunt
2017-09-22 9:56 ` Thomas Monjalon
2017-09-22 12:39 ` Hunt, David
2017-09-25 2:43 ` Wu, Jingjing
2017-09-25 9:57 ` Hunt, David
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 02/10] net/i40e: add API to get received packet count David Hunt
2017-09-25 2:47 ` Wu, Jingjing
2017-09-25 9:59 ` Hunt, David
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 03/10] lib/librte_power: add extra msg type for policies David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 04/10] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 05/10] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 06/10] examples/vm_power_mgr: add policy to channels David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 07/10] examples/vm_power_mgr: add port initialisation David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 08/10] examples/guest_cli: add send policy to host David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 09/10] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-08-25 16:02 ` [dpdk-dev] [PATCH v1 10/10] net/i40e: set register for no drop David Hunt
2017-09-25 2:50 ` Wu, Jingjing
2017-09-25 9:44 ` Hunt, David
2017-08-29 13:03 ` [dpdk-dev] [PATCH v1 0/10] Policy Based Power Control for Guest Ananyev, Konstantin
2017-09-22 9:51 ` Thomas Monjalon
2017-09-22 10:28 ` Hunt, David
2017-09-22 13:03 ` Thomas Monjalon
2017-09-22 13:12 ` Hunt, David
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2] " David Hunt
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 1/8] net/i40e: add API to convert VF MAC to VSI index David Hunt
2017-09-26 14:04 ` Wu, Jingjing
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 2/8] lib/librte_power: add extra msg type for policies David Hunt
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 3/8] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 4/8] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 5/8] examples/vm_power_mgr: add policy to channels David Hunt
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 6/8] examples/vm_power_mgr: add port initialisation David Hunt
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 7/8] examples/guest_cli: add send policy to host David Hunt
2017-09-25 12:27 ` [dpdk-dev] [PATCH v2 8/8] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4] Policy Based Power Control for Guest David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 1/9] net/i40e: add API to convert VF MAC to VF id David Hunt
2017-10-04 15:26 ` santosh
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 2/9] lib/librte_power: add extra msg type for policies David Hunt
2017-10-04 15:36 ` santosh [this message]
2017-10-05 8:38 ` Hunt, David
2017-10-05 9:21 ` santosh
2017-10-05 9:51 ` Hunt, David
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 4/9] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 5/9] examples/vm_power_mgr: add policy to channels David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 6/9] examples/vm_power_mgr: add port initialisation David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 7/9] power: add send channel msg function to map file David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 8/9] examples/guest_cli: add send policy to host David Hunt
2017-10-04 9:15 ` [dpdk-dev] [PATCH v4 9/9] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 0/9] Policy Based Power Control for Guest David Hunt
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 1/9] net/i40e: add API to convert VF MAC to VF id David Hunt
2017-10-04 15:41 ` santosh
2017-10-05 8:31 ` Hunt, David
2017-10-05 9:22 ` santosh
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 2/9] lib/librte_power: add extra msg type for policies David Hunt
2017-10-04 15:47 ` santosh
2017-10-05 8:41 ` Hunt, David
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-10-04 15:58 ` santosh
2017-10-05 8:44 ` Hunt, David
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 4/9] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-10-04 16:04 ` santosh
2017-10-05 8:47 ` Hunt, David
2017-10-05 9:07 ` santosh
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 5/9] examples/vm_power_mgr: add policy to channels David Hunt
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 6/9] examples/vm_power_mgr: add port initialisation David Hunt
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 7/9] power: add send channel msg function to map file David Hunt
2017-10-04 16:20 ` santosh
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 8/9] examples/guest_cli: add send policy to host David Hunt
2017-10-04 15:25 ` [dpdk-dev] [PATCH v5 9/9] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 0/9] Policy Based Power Control for Guest David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 1/9] net/i40e: add API to convert VF MAC to VF id David Hunt
2017-10-05 12:45 ` Ananyev, Konstantin
2017-10-05 12:51 ` Hunt, David
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 2/9] lib/librte_power: add extra msg type for policies David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 4/9] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 5/9] examples/vm_power_mgr: add policy to channels David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 6/9] examples/vm_power_mgr: add port initialisation David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 7/9] power: add send channel msg function to map file David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 8/9] examples/guest_cli: add send policy to host David Hunt
2017-10-05 12:25 ` [dpdk-dev] [PATCH v6 9/9] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 0/9] Policy Based Power Control for Guest David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 1/9] net/i40e: add API to convert VF MAC to VF id David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 2/9] lib/librte_power: add extra msg type for policies David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 4/9] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 5/9] examples/vm_power_mgr: add policy to channels David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 6/9] examples/vm_power_mgr: add port initialisation David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 7/9] power: add send channel msg function to map file David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 8/9] examples/guest_cli: add send policy to host David Hunt
2017-10-05 13:28 ` [dpdk-dev] [PATCH v7 9/9] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-05 13:54 ` [dpdk-dev] [PATCH v7 0/9] Policy Based Power Control for Guest Ananyev, Konstantin
2017-10-05 14:12 ` santosh
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 " David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 1/9] net/i40e: add API to convert VF MAC to VF id David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 2/9] lib/librte_power: add extra msg type for policies David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 4/9] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 5/9] examples/vm_power_mgr: add policy to channels David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 6/9] examples/vm_power_mgr: add port initialisation David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 7/9] power: add send channel msg function to map file David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 8/9] examples/guest_cli: add send policy to host David Hunt
2017-10-05 14:34 ` [dpdk-dev] [PATCH v8 9/9] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-09 22:34 ` [dpdk-dev] [PATCH v8 0/9] Policy Based Power Control for Guest Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb73493c-52c1-1637-8088-d7bc96f1432b@caviumnetworks.com \
--to=santosh.shukla@caviumnetworks.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=nemanja.marjanovic@intel.com \
--cc=rory.sexton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).