From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Mody, Rasesh" <Rasesh.Mody@cavium.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
"Thotton, Shijith" <Shijith.Thotton@cavium.com>,
Gregory Etelson <gregory@weka.io>,
"Patil, Harish" <Harish.Patil@cavium.com>,
dev@dpdk.org, George Prekas <george.prekas@epfl.ch>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
"Roberts, Lee A." <lee.roberts@hpe.com>
Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open
Date: Fri, 3 Nov 2017 15:20:44 -0700 [thread overview]
Message-ID: <ec1f6a0c-6a0c-b95e-e830-d1cda4da67ea@intel.com> (raw)
In-Reply-To: <12814007.65nxXEtm0z@xps>
On 11/3/2017 12:24 PM, Thomas Monjalon wrote:
> 03/11/2017 20:18, Mody, Rasesh:
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>>> On 11/2/2017 11:45 AM, Mody, Rasesh wrote:
>>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>>>>> On 11/2/2017 10:34 AM, Mody, Rasesh wrote:
>>>> We are ok as we have at least some way to disable the reset, please send a
>>> patch.
>>>
>>> Sent http://dpdk.org/dev/patchwork/patch/31143/, can you please test?
>>
>> The testing of BNX2X looks OK with this patch. However, the solution has following drawbacks:
>> - an application will need to be recompiled to have the igb_uio kernel module rebuilt to support bnx2x devices
>> - this will break pre-compiled solutions that are provided with an OS such as RHOSP or as part of a pre-compiled VNF
>>
>> We can live with this temporary solution for now. In the long term, we may have to revisit this.
>> We are also looking at why bnx2x FLR is taking this long.
>
> Yes, I think the long term solution should be to fix your PMD
> or your firmware.
> Please keep us posted when you find the root cause with your device.
> Thanks
Lee Roberts suggested doing device specific action instead of build time option.
I send following:
http://dpdk.org/dev/patchwork/patch/31168/
What do you think about this approach?
Meanwhile I will send a more proper patch to discuss on.
Thanks,
ferruh
next prev parent reply other threads:[~2017-11-03 22:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 20:14 [dpdk-dev] [PATCH] igb_uio: revert open and release operations Ferruh Yigit
2017-10-17 20:33 ` Thomas Monjalon
2017-10-18 4:50 ` Patil, Harish
2017-10-19 22:43 ` Patil, Harish
2017-10-20 1:15 ` Ferruh Yigit
2017-10-20 15:26 ` Tan, Jianfeng
2017-10-20 16:32 ` Ferruh Yigit
2017-10-20 16:55 ` [dpdk-dev] [PATCH] igb_uio: remove device reset in open Ferruh Yigit
2017-10-20 16:57 ` Ferruh Yigit
2017-10-20 19:01 ` Gregory Etelson
2017-10-20 22:18 ` Patil, Harish
2017-10-23 12:28 ` Shijith Thotton
2017-10-23 16:36 ` Ferruh Yigit
2017-10-23 19:03 ` Shijith Thotton
2017-10-25 23:43 ` Mody, Rasesh
2017-10-26 9:28 ` Tan, Jianfeng
2017-10-27 0:49 ` Ferruh Yigit
2017-11-01 6:58 ` Mody, Rasesh
2017-11-01 14:12 ` Stephen Hemminger
2017-11-02 8:03 ` Mody, Rasesh
2017-11-02 8:55 ` Ferruh Yigit
2017-11-02 17:34 ` Mody, Rasesh
2017-11-02 18:09 ` Ferruh Yigit
2017-11-02 18:45 ` Mody, Rasesh
2017-11-03 0:31 ` Ferruh Yigit
2017-11-03 19:18 ` Mody, Rasesh
2017-11-03 19:24 ` Thomas Monjalon
2017-11-03 22:20 ` Ferruh Yigit [this message]
2017-11-03 22:39 ` Ferruh Yigit
2017-10-24 21:38 ` Ferruh Yigit
2017-10-18 0:14 ` [dpdk-dev] [PATCH] igb_uio: revert open and release operations Wu, Jingjing
2017-10-18 6:27 ` Shijith Thotton
2017-10-18 20:47 ` Ferruh Yigit
2017-10-24 21:32 ` Ferruh Yigit
2017-10-22 16:06 [dpdk-dev] [PATCH] igb_uio: remove device reset in open Patil, Harish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1f6a0c-6a0c-b95e-e830-d1cda4da67ea@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Harish.Patil@cavium.com \
--cc=Rasesh.Mody@cavium.com \
--cc=Shijith.Thotton@cavium.com \
--cc=dev@dpdk.org \
--cc=george.prekas@epfl.ch \
--cc=gregory@weka.io \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=lee.roberts@hpe.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).