From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference
Date: Tue, 1 Aug 2017 09:13:10 +0100 [thread overview]
Message-ID: <ec4bd956-e079-8d0b-4ab2-41f6ec1b0ce5@intel.com> (raw)
In-Reply-To: <7230298.g0yYOUbsxP@xps>
On 31/07/2017 20:33, Thomas Monjalon wrote:
> 31/07/2017 11:18, Pablo de Lara:
>> When register a crypto driver, a cryptodev driver
>> structure was being allocated, using malloc.
>> Since this call may fail, it is safer to allocate
>> this memory statically in each PMD, so driver registration
>> will never fail.
>>
>> Coverity issue: 158645
>>
>> Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration")
>>
>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>> ---
>>
>> Changes in v2:
>>
>> - Allocate statically the cryptodev driver structure,
>> instead of using malloc, that can potentially fail.
>>
>> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 5 ++++-
>> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 6 +++++-
>> drivers/crypto/armv8/rte_armv8_pmd.c | 9 ++++++---
>> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 5 ++++-
>> drivers/crypto/kasumi/rte_kasumi_pmd.c | 5 ++++-
>> drivers/crypto/null/null_crypto_pmd.c | 5 ++++-
>> drivers/crypto/openssl/rte_openssl_pmd.c | 5 ++++-
>> drivers/crypto/qat/rte_qat_cryptodev.c | 7 +++++--
>> drivers/crypto/scheduler/scheduler_pmd.c | 5 ++++-
>> drivers/crypto/snow3g/rte_snow3g_pmd.c | 5 ++++-
>> drivers/crypto/zuc/rte_zuc_pmd.c | 5 ++++-
>> lib/librte_cryptodev/rte_cryptodev.c | 18 +++++------------
>> lib/librte_cryptodev/rte_cryptodev.h | 20 -------------------
>> lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 +++++++++++++++++++++++++++++
>> 14 files changed, 83 insertions(+), 47 deletions(-)
> This is a big change for a small/unlikely issue.
> The main benefit of this patch is an allocation cleanup.
> I think it is better to wait 17.11 cycle to integrate it.
We initially thought of exit given that it is a constructor and if you
fail to allocate memory at this stage, things are likely not going to
work out anyway.
The patch is an API change, do we really want to break again (we are
breaking in this release) next release?
Thanks,
Sergio
next prev parent reply other threads:[~2017-08-01 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 2:30 [dpdk-dev] [PATCH] " Pablo de Lara
2017-07-31 9:18 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-07-31 19:33 ` Thomas Monjalon
2017-08-01 7:10 ` De Lara Guarch, Pablo
2017-08-01 8:13 ` Sergio Gonzalez Monroy [this message]
2017-08-01 9:35 ` Thomas Monjalon
2017-08-01 10:17 ` Sergio Gonzalez Monroy
2017-08-01 10:48 ` De Lara Guarch, Pablo
2017-08-01 12:36 ` Thomas Monjalon
2017-08-16 2:41 ` [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure statically Pablo de Lara
2017-09-04 10:38 ` Rybalchenko, Kirill
2017-09-06 10:27 ` De Lara Guarch, Pablo
2017-07-31 12:32 ` [dpdk-dev] [PATCH] cryptodev: fix NULL pointer dereference Sergio Gonzalez Monroy
2017-07-31 15:22 ` Thomas Monjalon
2017-08-01 7:09 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec4bd956-e079-8d0b-4ab2-41f6ec1b0ce5@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).