From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, techboard@dpdk.org
Subject: Re: [PATCH] bus/vdev: automatically add eth alias for net drivers
Date: Thu, 27 Oct 2022 09:35:59 +0100 [thread overview]
Message-ID: <ed0aba6e-3e7b-d47e-0488-19fdb17e1ba3@amd.com> (raw)
In-Reply-To: <CAJFAV8yh6-oxjq8XfcE_TQpgbUazf6uRZevT06frP6SM=r=mjg@mail.gmail.com>
On 10/27/2022 8:58 AM, David Marchand wrote:
> On Thu, Oct 20, 2022 at 1:52 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>>>> Honestly I think the status quo is OK:
>>>> We have some aliases in some PMD for some historical reason
>>>> and everybody looks OK with that. Isn't it?
>>>>
>>>
>>> Well, the inconsistency bugs me a little, but if others feel the status quo
>>> is ok, I'm ok with that.
>>
>> In my perspective this is for cleanup, and new PMDs keep adding alias
>> because they are copying from existing drivers.
>> Except from above there is no harm to have alias.
>
> Do we have a "valid" case of adding new aliases?
> I don't think it is the case, so we can warn of new aliases
> introduction in checkpatches.sh.
>
I commented a few of them to drop alias.
checkpatch can be an option, but my intention was to drop old code to
reduce noise, not to add more :)
OK to keep the alias if removing it will cause more trouble.
> At worse, if a valid case is identified later, checkpatches.sh is only
> a warning in patchwork and maintainers will manually review this
> warning.
>
>
next prev parent reply other threads:[~2022-10-27 8:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 13:34 [PATCH] drivers/net: remove alias for virtual devices Ferruh Yigit
2022-09-21 14:26 ` Thomas Monjalon
2022-09-21 14:43 ` Ferruh Yigit
2022-09-21 14:49 ` Bruce Richardson
2022-10-19 13:13 ` Bruce Richardson
2022-11-06 10:43 ` Andrew Rybchenko
2022-10-19 13:11 ` [PATCH] bus/vdev: automatically add eth alias for net drivers Bruce Richardson
2022-10-19 13:20 ` Bruce Richardson
2022-10-20 8:23 ` Thomas Monjalon
2022-10-20 8:48 ` Bruce Richardson
2022-10-20 11:51 ` Ferruh Yigit
2022-10-27 7:58 ` David Marchand
2022-10-27 8:35 ` Ferruh Yigit [this message]
2023-01-12 11:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0aba6e-3e7b-d47e-0488-19fdb17e1ba3@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).