From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Radu Nicolau <radu.nicolau@intel.com>, dev@dpdk.org
Cc: declan.doherty@intel.com, chas3@att.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/bonding: fix crash when stopping mode 4 port
Date: Fri, 9 Nov 2018 20:49:43 +0000 [thread overview]
Message-ID: <ed5f6703-7f45-80cb-0d62-048fcbf5f319@intel.com> (raw)
In-Reply-To: <1541690802-16121-1-git-send-email-radu.nicolau@intel.com>
On 11/8/2018 3:26 PM, Radu Nicolau wrote:
> When stopping a bonded port all slaves are deactivated. Attempting
> to deactivate a slave that was never activated will result in a segfault
> when mode 4 is used.
>
> Fixes: 7486331308f6 ("net/bonding: stop and deactivate slaves on stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 1a6d8e4..2661620 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -2181,9 +2181,14 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev)
>
> internals->link_status_polling_enabled = 0;
> for (i = 0; i < internals->slave_count; i++) {
> - internals->slaves[i].last_link_status = 0;
> - rte_eth_dev_stop(internals->slaves[i].port_id);
> - deactivate_slave(eth_dev, internals->slaves[i].port_id);
> + uint16_t slave_id = internals->slaves[i].port_id;
> + if (find_slave_by_id(internals->active_slaves,
> + internals->active_slave_count, slave_id) !=
> + internals->active_slave_count) {
> + internals->slaves[i].last_link_status = 0;
> + rte_eth_dev_stop(slave_id);
> + deactivate_slave(eth_dev, slave_id);
> + }
> }
> }
Hi Chas, Declan,
Any comment on patch? I think we should have this for rc3.
next prev parent reply other threads:[~2018-11-09 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 15:26 Radu Nicolau
2018-11-09 20:49 ` Ferruh Yigit [this message]
2018-11-09 21:40 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2018-11-09 22:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed5f6703-7f45-80cb-0d62-048fcbf5f319@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).