From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
"Hunt, David" <david.hunt@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Guo, Jia" <jia.guo@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Liang Ma <liang.j.ma@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver
Date: Wed, 28 Apr 2021 01:21:35 +0000 [thread overview]
Message-ID: <ede3a9fb327b4ca8a089b7927a662d98@intel.com> (raw)
In-Reply-To: <BN8PR11MB379524E6B9A4C051D5FF898BF7419@BN8PR11MB3795.namprd11.prod.outlook.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue
> Sent: Tuesday, April 27, 2021 9:43 AM
> To: Hunt, David <david.hunt@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; dev@dpdk.org; Guo, Jia <jia.guo@intel.com>;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Liang Ma
> <liang.j.ma@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for
> VF driver
>
> > -----Original Message-----
> > From: Hunt, David <david.hunt@intel.com>
> > Sent: Monday, April 26, 2021 22:20
> > To: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org; Guo,
> > Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> > Ananyev, Konstantin <konstantin.ananyev@intel.com>; Liang Ma
> > <liang.j.ma@intel.com>
> > Subject: Re: [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF
> > driver
> >
> > Hi Anatoly,
> >
> > On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> > > When .get_monitor_addr API was introduced, it was implemented in the
> > > ixgbe driver, but only for the physical function; the virtual
> > > function portion of the driver does not support that API.
> > >
> > > Add the missing function pointer to VF device structure.
> > >
> > > Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API")
> > >
> > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > > ---
> > > drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > index ff65145f55..6cca039a11 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > @@ -605,6 +605,7 @@ static const struct eth_dev_ops
> ixgbevf_eth_dev_ops = {
> > > .rss_hash_update = ixgbe_dev_rss_hash_update,
> > > .rss_hash_conf_get = ixgbe_dev_rss_hash_conf_get,
> > > .tx_done_cleanup = ixgbe_dev_tx_done_cleanup,
> > > + .get_monitor_addr = ixgbe_get_monitor_addr,
> > > };
> > >
> > > /* store statistics names and its offset in stats structure */
> >
> >
> > Thanks for the fix. I ran get_monitor_address() on some ixgbe virtual
> > functions here, and can confirm that this patch resolves the issue.
> >
> > Reviewed-by: David Hunt <david.hunt@intel.com>
> >
> >
>
> Nice confirmation, thanks, David.
>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2021-04-28 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 13:49 Anatoly Burakov
2021-04-26 13:49 ` [dpdk-dev] [PATCH v1 2/2] net/i40e: " Anatoly Burakov
2021-04-26 14:22 ` David Hunt
2021-04-28 1:22 ` Zhang, Qi Z
2021-04-26 14:20 ` [dpdk-dev] [PATCH v1 1/2] net/ixgbe: " David Hunt
2021-04-27 1:42 ` Wang, Haiyue
2021-04-28 1:21 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede3a9fb327b4ca8a089b7927a662d98@intel.com \
--to=qi.z.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=liang.j.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).