From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/7] ethdev: reduce goto's in attach/detach
Date: Wed, 1 Feb 2017 17:26:49 +0000 [thread overview]
Message-ID: <ede43a63-baa7-e33f-31be-8e4a41b753ad@intel.com> (raw)
In-Reply-To: <29688688.OdmTMFx9gs@xps13>
On 1/10/2017 8:40 AM, Thomas Monjalon wrote:
> Hi Stephen,
>
> Please use --in-reply-to to keep v1 and v2 in the same thread.
>
> Comment below
>
>
> 2017-01-09 15:30, Stephen Hemminger:
>> int
>> rte_eth_dev_detach(uint8_t port_id, char *name)
>> {
>> - int ret = -1;
>> + int ret;
>>
>> - if (name == NULL) {
>> - ret = -EINVAL;
>> - goto err;
>> - }
>> + if (name == NULL)
>> + return -EINVAL;
>>
>> /* FIXME: move this to eal, once device flags are relocated there */
>> - if (rte_eth_dev_is_detachable(port_id))
>> - goto err;
>> + ret = rte_eth_dev_is_detachable(port_id);
>> + if (ret < 0)
>> + return ret;
>
> As commented on v1 by Ferruh and I, you should check also positive value.
In case it is not obvious, this patchset is stuck because of above
change request not addressed.
>
>>
>> snprintf(name, sizeof(rte_eth_devices[port_id].data->name),
>> "%s", rte_eth_devices[port_id].data->name);
>> - ret = rte_eal_dev_detach(name);
>> - if (ret < 0)
>> - goto err;
>>
>> - return 0;
>> -
>> -err:
>> - return ret;
>> + return rte_eal_dev_detach(name);
>> }
>
next prev parent reply other threads:[~2017-02-01 17:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 23:30 [dpdk-dev] [PATCH v2 0/7] minor cleanup Stephen Hemminger
2017-01-09 23:30 ` [dpdk-dev] [PATCH 1/7] bonding, malloc, bitmap: remove useless return Stephen Hemminger
2017-01-09 23:30 ` [dpdk-dev] [PATCH 2/7] ethdev: reduce goto's in attach/detach Stephen Hemminger
2017-01-10 8:40 ` Thomas Monjalon
2017-02-01 17:26 ` Ferruh Yigit [this message]
2017-01-09 23:30 ` [dpdk-dev] [PATCH 3/7] bnx2x: remove useless return's Stephen Hemminger
2017-01-09 23:30 ` [dpdk-dev] [PATCH 4/7] kni: remove useless return statements Stephen Hemminger
2017-01-11 17:36 ` Ferruh Yigit
2017-01-09 23:30 ` [dpdk-dev] [PATCH 5/7] i40e: remove useless return Stephen Hemminger
2017-01-09 23:30 ` [dpdk-dev] [PATCH 6/7] ixgbe: " Stephen Hemminger
2017-02-01 16:40 ` Ananyev, Konstantin
2017-02-08 14:43 ` Dai, Wei
2017-01-09 23:30 ` [dpdk-dev] [PATCH 7/7] igb: remove useless return's Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede43a63-baa7-e33f-31be-8e4a41b753ad@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).