From: "Tom Jones" <thj@freebsd.org>
To: "David Marchand" <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>
Subject: Re: [PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD
Date: Thu, 21 Mar 2024 10:33:22 +0000 [thread overview]
Message-ID: <ee6474ae-0678-4dea-b171-173f39f22657@app.fastmail.com> (raw)
In-Reply-To: <CAJFAV8z-qujGHbN4RQqGOQA1-ALwHV36gGZ7pGOdrnxQ==+1Jw@mail.gmail.com>
On Thu, Mar 21, 2024, at 10:15, David Marchand wrote:
> Hello Tom,
>
> On Thu, Mar 21, 2024 at 11:00 AM Tom Jones <thj@freebsd.org> wrote:
>>
>> Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 driver
>> as they are not supported. Rx queue interrupts were missed by this
>> change, don't attempt to enable them on FreeBSD.
>>
>> Without this change applications enabling interrupts encounter an
>> immediate abort on FreeBSD.
>
> Thanks for the patch, you will probably want this fix backported in
> LTS versions.
> If so, please add a Fixes: tag and Cc: stable@dpdk.org.
> I guess here, it is:
> Fixes: 40d5676ff1ea ("net/vmxnet3: fix initialization on FreeBSD")
Thanks! updated
>
> Reading again the commitlog, I wonder if we should error out in
> vmxnet3_configure_msix() if rx (and/or lsc) interrupts are requested
> for FreeBSD.
> Did you consider this approach?
>
I haven't dug much futher into this. I also changed the application side (vpp) to not request interrupts. I think there are probably some other FreeBSD specific cases to explore in vmxnet3, but I don't have a great environment for testing yet.
- Tom
next prev parent reply other threads:[~2024-03-21 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 13:02 Tom Jones
2024-03-21 9:50 ` Tom Jones
2024-03-21 10:15 ` David Marchand
2024-03-21 10:33 ` Tom Jones [this message]
2024-03-21 10:31 ` Tom Jones
2024-03-21 14:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6474ae-0678-4dea-b171-173f39f22657@app.fastmail.com \
--to=thj@freebsd.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).