From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: Nipun Gupta <nipun.gupta@nxp.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Cc: "gage.eads@intel.com" <gage.eads@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
"narender.vangati@intel.com" <narender.vangati@intel.com>,
"erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
"abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev
Date: Thu, 14 Sep 2017 08:34:20 +0530 [thread overview]
Message-ID: <ee6b590e-0769-b7b3-dfb4-ac3397e11d60@intel.com> (raw)
In-Reply-To: <HE1PR0401MB242514782ABB9555743088F9E66E0@HE1PR0401MB2425.eurprd04.prod.outlook.com>
On 9/13/2017 7:06 PM, Nipun Gupta wrote:
>
>
>> -----Original Message-----
>> From: Nikhil Rao [mailto:nikhil.rao@intel.com]
>> ---
>> lib/librte_eventdev/rte_eventdev_pmd.h | 6 ++++++
>> drivers/event/sw/sw_evdev.c | 13 +++++++++++++
>> 2 files changed, 19 insertions(+)
>>
>> diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h
>> b/lib/librte_eventdev/rte_eventdev_pmd.h
>> index 4cc9671..3cbc063 100644
>> --- a/lib/librte_eventdev/rte_eventdev_pmd.h
>> +++ b/lib/librte_eventdev/rte_eventdev_pmd.h
>> @@ -83,6 +83,12 @@ extern "C" {
>> } \
>> } while (0)
>>
>> +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \
>> + RTE_EVENT_ETH_RX_ADAPTER_CAP_FLOW_ID
>> +/**< Ethernet Rx adapter cap to return If the packet transfers from
>> + * the ethdev to eventdev use a SW service function
>> + */
>
> Hi Nikhil,
>
> Maybe it makes more sense to have RTE_EVENT_ETH_RX_ADAPTER_SW_CAP #define in 'sw_evdev.h' file?
>
The usage of this #define is not intended to be restricted to sw_evdev.c.
Eventdev PMDs may need to use the SW implementation of ethdev to
eventdev packet transfer for some eth ports (e.g., veth) while they may
support a HW transfer mechanism for SoC eth ports, in that case the
eventdev PMD would need access to this define. Hope that answers your
question.
Thanks,
Nikhil
next prev parent reply other threads:[~2017-09-14 3:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 12:29 [dpdk-dev] [PATCH v3 0/4] eventdev: cover letter: ethernet Rx queue event adapter Nikhil Rao
2017-09-12 12:29 ` [dpdk-dev] [PATCH v3 1/4] eventdev: Add caps API and PMD callbacks for rte_event_eth_rx_adapter Nikhil Rao
2017-09-12 12:29 ` [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev Nikhil Rao
2017-09-13 13:36 ` Nipun Gupta
2017-09-14 3:04 ` Rao, Nikhil [this message]
2017-09-14 4:37 ` Nipun Gupta
2017-09-12 12:29 ` [dpdk-dev] [PATCH v3 3/4] eventdev: Add eventdev ethernet Rx adapter Nikhil Rao
2017-09-12 4:17 ` Jerin Jacob
2017-09-13 9:41 ` Rao, Nikhil
2017-09-13 18:53 ` [dpdk-dev] [PATCH " Nikhil Rao
2017-09-15 6:07 ` Nipun Gupta
2017-09-18 4:54 ` Rao, Nikhil
2017-09-15 6:10 ` santosh
2017-09-15 11:10 ` Rao, Nikhil
2017-09-15 14:26 ` santosh
2017-09-18 15:36 ` Van Haaren, Harry
2017-09-19 15:25 ` Rao, Nikhil
2017-09-12 12:29 ` [dpdk-dev] [PATCH v3 4/4] eventdev: Add tests for event eth Rx adapter APIs Nikhil Rao
2017-09-15 6:07 ` santosh
2017-09-18 15:40 ` Van Haaren, Harry
2017-09-21 12:36 ` [dpdk-dev] [PATCH v3 0/4] eventdev: cover letter: ethernet Rx queue event adapter Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6b590e-0769-b7b3-dfb4-ac3397e11d60@intel.com \
--to=nikhil.rao@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narender.vangati@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).