From: David Vodak <vodak@cesnet.cz>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal: introduce missing rte_thread wrappers
Date: Tue, 28 Nov 2023 09:54:02 +0100 [thread overview]
Message-ID: <ee92afd2-eb4a-c287-ba8c-bbd2b0dab12b@cesnet.cz> (raw)
In-Reply-To: <20231127172722.GA14975@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On 11/27/23 18:27, Tyler Retzlaff wrote:
> On Mon, Nov 27, 2023 at 10:25:02AM +0100, David Vodak wrote:
>> Function rte_ctrl_thread_create has been replaced by rte_thread_create_control,
>> encouraging Linux users to switch from the pthread_t API to the rte_thread API.
>> However the rte_thread API does not provide wrappers for all pthread functions.
>> This commit introduces equivalent functions for pthread_timedjoin_np,
>> pthread_getname_np and pthread_cancel.
>>
>> Bugzilla ID: 1330
>> ---
> NAK this series. the rte thread API is not a POSIX emulation API.
>
> the point of EAL is not to require applications to have to conditionally
> compile code around the use of EAL API or handle "not supported"
> failures it defeats the purpose of being an abstraction library.
Hi,
I understand that these changes may not be the best alternative. But
what other options do we have,
if we are already using functions such as pthread_timedjoin_np? Should
we just keep using them and
treat rte_thread_id.opaque_id as pthread_t?
Regards
David Vodak
next prev parent reply other threads:[~2023-11-28 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 9:25 David Vodak
2023-11-27 17:14 ` Stephen Hemminger
2023-11-27 17:27 ` Tyler Retzlaff
2023-11-28 8:54 ` David Vodak [this message]
2023-11-29 15:52 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee92afd2-eb4a-c287-ba8c-bbd2b0dab12b@cesnet.cz \
--to=vodak@cesnet.cz \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).