From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Harini.Ramakrishnan@microsoft.com, navasile@linux.microsoft.com
Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,
Narcisa.Vasile@microsoft.com, tbashar@mellanox.com,
talshn@mellanox.com, fady@mellanox.com
Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: fix warnings on Windows
Date: Thu, 11 Jun 2020 11:55:41 -0700 [thread overview]
Message-ID: <ef247ebe-889a-0783-2ae2-a83de841154d@intel.com> (raw)
In-Reply-To: <1597883.oqJHaQj4sU@thomas>
On 6/11/2020 9:14 AM, Thomas Monjalon wrote:
> 29/05/2020 01:14, Pallavi Kadam:
>> Fixed bunch of warnings when compiling using clang on Windows
>> such as the use of an unsafe string function (strerror),
>> [-Wunused-variable], [-Wunused-function] in eal_common_options.c
>> [-Wunused-const-variable] in getopt.c and [-Wunused-parameter]
>> in eal_common_thread.c.
>> Also fixed warnings generated using Mingw:
>> [-Werror=old-style-definition], [-Werror=cast-function-type] and
>> [-Werror=attributes]
>>
>> Signed-off-by: Ranjit Menon <ranjit.menon@intel.com>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
>
> Tested-by is useless if you are the author of the patch.
>
Sorry for this, will remove the tag in v4.
>> lib/librte_eal/common/eal_common_options.c | 8 +++++++-
>> lib/librte_eal/windows/eal.c | 2 +-
>> lib/librte_eal/windows/eal_lcore.c | 2 +-
>> lib/librte_eal/windows/eal_thread.c | 3 ++-
>> lib/librte_eal/windows/getopt.c | 4 ++--
>> lib/librte_eal/windows/include/pthread.h | 6 ++++--
>> 6 files changed, 17 insertions(+), 8 deletions(-)
>
> There were some changes since v2 which were not reviewed.
> Someone please?
>
>
next prev parent reply other threads:[~2020-06-11 18:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 22:53 [dpdk-dev] [PATCH] " Pallavi Kadam
2020-05-14 0:43 ` Dmitry Kozlyuk
2020-05-14 1:24 ` Ranjit Menon
2020-05-14 8:02 ` Thomas Monjalon
2020-05-14 17:46 ` Ranjit Menon
2020-05-14 20:39 ` [dpdk-dev] [PATCH v2] " Pallavi Kadam
2020-05-15 19:20 ` Dmitry Kozlyuk
2020-05-18 22:08 ` Narcisa Ana Maria Vasile
2020-05-28 23:14 ` [dpdk-dev] [PATCH v3 0/2] Fix Windows compiler warnings Pallavi Kadam
2020-05-28 23:14 ` [dpdk-dev] [PATCH v3 1/2] eal: fix warnings on Windows Pallavi Kadam
2020-06-11 16:14 ` Thomas Monjalon
2020-06-11 18:55 ` Kadam, Pallavi [this message]
2020-05-28 23:14 ` [dpdk-dev] [PATCH v3 2/2] build: treat warning as an error " Pallavi Kadam
2020-06-11 16:12 ` Thomas Monjalon
2020-06-11 18:54 ` Kadam, Pallavi
2020-06-11 19:50 ` [dpdk-dev] [PATCH v4] eal: fix warnings " Pallavi Kadam
2020-06-11 20:18 ` Narcisa Ana Maria Vasile
2020-06-15 9:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef247ebe-889a-0783-2ae2-a83de841154d@intel.com \
--to=pallavi.kadam@intel.com \
--cc=Harini.Ramakrishnan@microsoft.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=navasile@linux.microsoft.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).