DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix use-after-free issue on thread creation
Date: Wed, 2 May 2018 21:54:11 +0800	[thread overview]
Message-ID: <ef6beaee-bf29-2d91-a50c-c3c1fa6850e7@intel.com> (raw)
In-Reply-To: <20180502112417.shlwamchx4as4sqw@neon>

Hi Olivier,


On 5/2/2018 7:24 PM, Olivier Matz wrote:
> Hi Jianfeng,
>
> On Wed, May 02, 2018 at 10:17:50AM +0000, Jianfeng Tan wrote:
>> After below commit, we encounter some strange issue:
>>    1) Dead lock as described here:
>>       http://dpdk.org/ml/archives/dev/2018-April/099806.html
>>    2) SIGSEGV issue when starting a testpmd in VM.
>>
>> Considering below commit changes to use dynamic memory instead of
>> stack for memory barrier, we doubt it's caused by use-after-free.
>>
>> Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier")
>>
>> Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Reported-by: Lei Yao <lei.a.yao@intel.com>
>> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>> ---
>>   v1->v2:
>>   - Destroy barrier if failure happens.
>>   lib/librte_eal/common/eal_common_thread.c | 15 ++++++++++++---
>>   1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
>> index de69452..5f0c61f 100644
>> --- a/lib/librte_eal/common/eal_common_thread.c
>> +++ b/lib/librte_eal/common/eal_common_thread.c
>> @@ -149,11 +149,16 @@ struct rte_thread_ctrl_params {
>>   
>>   static void *rte_thread_init(void *arg)
>>   {
>> +	int ret;
>>   	struct rte_thread_ctrl_params *params = arg;
>>   	void *(*start_routine)(void *) = params->start_routine;
>>   	void *routine_arg = params->arg;
>>   
>> -	pthread_barrier_wait(&params->configured);
>> +	ret = pthread_barrier_wait(&params->configured);
>> +	if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
>> +		pthread_barrier_destroy(&params->configured);
>> +		free(params);
>> +	}
>>   
>>   	return start_routine(routine_arg);
>>   }
>> @@ -204,12 +209,16 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
>>   	if (ret < 0)
>>   		goto fail;
>>   
>> -	pthread_barrier_wait(&params->configured);
>> -	free(params);
>> +	ret = pthread_barrier_wait(&params->configured);
>> +	if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
>> +		pthread_barrier_destroy(&params->configured);
>> +		free(params);
>> +	}
>>   
>>   	return 0;
>>   
>>   fail:
>> +	pthread_barrier_destroy(&params->configured);
> I think we should have the same code than above in the fail case:
>
> 	ret = pthread_barrier_wait(&params->configured);
> 	if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
> 		pthread_barrier_destroy(&params->configured);
> 		free(params);
> 	}
>
> Else, the child will wait forever on the barrier on failure.

Make sense. I send v3 patch according to your advice, except that not 
polluting ret.

Thanks,
Jianfeng

>
> This can be tested with this standalone program:
> https://www.droids-corp.org/~zer0/hidden/ctrl_thread.c
>
> gcc -W -Wall -Werror -Wextra -pthread ctrl_thread.c
> ./a.out -> fail
>
> gcc -W -Wall -Werror -Wextra -pthread -DFIX ctrl_thread.c
> ./a.out -> ok
>
>
>
>>   	pthread_cancel(*thread);
>>   	pthread_join(*thread, NULL);
>>   	free(params);
>> -- 
>> 2.7.4
>>

next prev parent reply	other threads:[~2018-05-02 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  9:59 [dpdk-dev] [PATCH] " Jianfeng Tan
2018-05-02 10:17 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
2018-05-02 11:24   ` Olivier Matz
2018-05-02 13:54     ` Tan, Jianfeng [this message]
2018-05-02 13:52 ` [dpdk-dev] [PATCH v3] " Jianfeng Tan
2018-05-02 14:56   ` Olivier Matz
2018-05-02 15:26     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef6beaee-bf29-2d91-a50c-c3c1fa6850e7@intel.com \
    --to=jianfeng.tan@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).