From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Tudor Cornea <tudor.cornea.keysight@gmail.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Tudor Cornea <tudor.cornea@keysight.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix integer overflow when computing max_pkt_len
Date: Mon, 21 Jun 2021 04:20:13 +0000 [thread overview]
Message-ID: <efbb7312508e4d36b50f63d33f1cbfd9@intel.com> (raw)
In-Reply-To: <1623753514-36187-1-git-send-email-tudor.cornea@keysight.com>
> -----Original Message-----
> From: Tudor Cornea <tudor.cornea.keysight@gmail.com>
> Sent: Tuesday, June 15, 2021 6:39 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Tudor Cornea <tudor.cornea@keysight.com>
> Subject: [PATCH] net/ice: fix integer overflow when computing max_pkt_len
>
> The len variable, used in the computation of max_pkt_len could overflow, if
> used to store the result of the following computation:
>
> ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len
>
> Since, we could define the mbuf size to have a large value (i.e 13312), and
> ICE_SUPPORT_CHAIN_NUM is defined as 5, the computation mentioned above
> could potentially result in a value which might be bigger than MAX_USHORT.
>
> The result will be that Jumbo Frames will not work properly
>
> Signed-off-by: Tudor Cornea <tudor.cornea@keysight.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel after adding missing fixline and cc stable
Fixes: 1b009275e2c8 ("net/ice: add Rx queue init in DCF")
Cc: stable@dpdk.org
Thanks
Qi
next prev parent reply other threads:[~2021-06-21 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:38 Tudor Cornea
2021-06-21 4:20 ` Zhang, Qi Z [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-15 9:58 Tudor Cornea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efbb7312508e4d36b50f63d33f1cbfd9@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=tudor.cornea.keysight@gmail.com \
--cc=tudor.cornea@keysight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).